refactor: move dbt integration types and constants to domain module

Author: mdesmet

src/autocompletion_provider/modelAutocompletionProvider.ts

@@ -15,7 +15,7 @@ import { DBTProjectContainer } from "../manifest/dbtProjectContainer";
 import { ManifestCacheChangedEvent } from "../manifest/event/manifestCacheChangedEvent";
 import { isEnclosedWithinCodeBlock, provideSingleton } from "../utils";
 import { TelemetryService } from "../telemetry";
-import { RESOURCE_TYPE_ANALYSIS } from "../dbt_integration/dbtIntegration";
+import { RESOURCE_TYPE_ANALYSIS } from "../dbt_integration/domain";
 
 @provideSingleton(ModelAutocompletionProvider) // TODO autocomplete doesn't work when mistype, delete and retype
 export class ModelAutocompletionProvider

src/commands/tests/initCatalog.ts

@@ -1,4 +1,4 @@
-import { Catalog } from "../../dbt_integration/dbtIntegration";
+import { Catalog } from "../../dbt_integration/domain";
 import { provideSingleton } from "../../utils";
 import { ScanContext } from "./scanContext";
 import { AltimateScanStep } from "./step";

src/commands/tests/missingSchemaTest.ts

@@ -2,7 +2,7 @@ import { Diagnostic, DiagnosticSeverity, Range } from "vscode";
 import { ScanContext } from "./scanContext";
 import { AltimateScanStep } from "./step";
 import { provideSingleton } from "../../utils";
-import { RESOURCE_TYPE_MODEL } from "../../dbt_integration/dbtIntegration";
+import { RESOURCE_TYPE_MODEL } from "../../dbt_integration/domain";
 
 @provideSingleton(MissingSchemaTest)
 export class MissingSchemaTest implements AltimateScanStep {

src/commands/tests/scanContext.ts

@@ -1,4 +1,4 @@
-import { Catalog } from "../../dbt_integration/dbtIntegration";
+import { Catalog } from "../../dbt_integration/domain";
 import { DBTProject } from "../../manifest/dbtProject";
 import { ManifestCacheProjectAddedEvent } from "../../manifest/event/manifestCacheChangedEvent";
 import { Diagnostic } from "vscode";

src/comment_provider/conversationProvider.ts

@@ -30,7 +30,7 @@ import { inject } from "inversify";
 import {
   RESOURCE_TYPE_MACRO,
   RESOURCE_TYPE_TEST,
-} from "../dbt_integration/dbtIntegration";
+} from "../dbt_integration/domain";
 
 // Extends vscode commentthread and add extra fields for reference
 export interface ConversationCommentThread extends CommentThread {

src/content_provider/sqlPreviewContentProvider.ts

@@ -17,7 +17,7 @@ import { TelemetryService } from "../telemetry";
 import { DeferToProdService } from "../services/deferToProdService";
 import { DbtIntegrationClient } from "../dbt_integration/dbtIntegrationClient";
 import path = require("path");
-import { ManifestPathType } from "../dbt_integration/dbtIntegration";
+import { ManifestPathType } from "../dbt_integration/domain";
 
 @provideSingleton(SqlPreviewContentProvider)
 export class SqlPreviewContentProvider

src/dbt_integration/dbtCloudIntegration.ts

@@ -1,8 +1,5 @@
 import { DBTDiagnosticData, DBTDiagnosticResult } from "./diagnostics";
 import {
-  Catalog,
-  DBColumn,
-  DBTNode,
   DBTCommand,
   DBTCommandExecutionInfrastructure,
   DBTCommandExecutionStrategy,
@@ -11,8 +8,6 @@ import {
   DBTProjectDetection,
   DBTProjectIntegration,
   QueryExecution,
-  DBT_PROJECT_FILE,
-  DeferConfig,
   readAndParseProjectConfig,
 } from "./dbtIntegration";
 import { CommandProcessExecutionFactory } from "./commandProcessExecution";
@@ -23,7 +18,14 @@ import { DBTTerminal } from "./terminal";
 import { RuntimePythonEnvironment } from "./pythonEnvironment";
 import { existsSync, readFileSync } from "fs";
 import semver = require("semver");
-import { NodeMetaData } from "./domain";
+import {
+  Catalog,
+  DBColumn,
+  DBT_PROJECT_FILE,
+  DBTNode,
+  DeferConfig,
+  NodeMetaData,
+} from "./domain";
 import * as crypto from "crypto";
 import { parse } from "yaml";
 

src/dbt_integration/dbtCoreCommandIntegration.ts

@@ -3,14 +3,9 @@ import {
   DBTCoreProjectDetection,
   DBTCoreProjectIntegration,
 } from "./dbtCoreIntegration";
-import {
-  QueryExecution,
-  DBTCommand,
-  DBColumn,
-  Catalog,
-  DBTNode,
-} from "./dbtIntegration";
+import { QueryExecution, DBTCommand } from "./dbtIntegration";
 import { getDBTPath } from "./dbtCloudIntegration";
+import { Catalog, DBColumn, DBTNode } from "./domain";
 
 // TODO: either fix this class or remove it
 export class DBTCoreCommandDetection extends DBTCoreDetection {}

src/dbt_integration/dbtCoreIntegration.ts

@@ -1,9 +1,6 @@
 import { DBTDiagnosticData, DBTDiagnosticResult } from "./diagnostics";
 import {
-  Catalog,
   CompilationResult,
-  DBColumn,
-  DBTNode,
   DBTCommand,
   DBTCommandExecutionInfrastructure,
   DBTDetection,
@@ -12,14 +9,8 @@ import {
   ExecuteSQLResult,
   PythonDBTCommandExecutionStrategy,
   QueryExecution,
-  SourceNode,
-  Node,
   ExecuteSQLError,
   DBTCommandExecutionStrategy,
-  DBT_PROJECT_FILE,
-  RESOURCE_TYPE_SOURCE,
-  DeferConfig,
-  ManifestPathType,
 } from "./dbtIntegration";
 import { RuntimePythonEnvironment } from "./pythonEnvironment";
 import { CommandProcessExecutionFactory } from "./commandProcessExecution";
@@ -31,7 +22,18 @@ import { parse } from "yaml";
 import { NotFoundError } from "./altimateHttpClient";
 import { DBTTerminal } from "./terminal";
 import { DBTConfiguration } from "./configuration";
-import { NodeMetaData } from "./domain";
+import {
+  Catalog,
+  DBColumn,
+  DBT_PROJECT_FILE,
+  DBTNode,
+  DeferConfig,
+  ManifestPathType,
+  Node,
+  NodeMetaData,
+  RESOURCE_TYPE_SOURCE,
+  SourceNode,
+} from "./domain";
 import * as crypto from "crypto";
 import { DbtIntegrationClient } from "./dbtIntegrationClient";
 

src/dbt_integration/dbtFacade.ts

@@ -1,7 +1,13 @@
 import { CommandProcessResult } from "./commandProcessExecution";
-import { RunModelParams, DBTNode, DBColumn, Catalog } from "./dbtIntegration";
 import { ProjectHealthcheck } from "./dbtCoreIntegration";
-import { DataPilotHealtCheckParams, Table } from "./domain";
+import {
+  Catalog,
+  DataPilotHealtCheckParams,
+  DBColumn,
+  DBTNode,
+  RunModelParams,
+  Table,
+} from "./domain";
 
 /**
  * Framework-agnostic facade interface for dbt project operations.