Skip to content

fix: Run Test action now recognizes singular data tests (#1720) #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/commands/runModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ export class RunModel {
return;
}
const fullPath = window.activeTextEditor.document.uri;

// Check if the file is in the tests directory (singular test)
const relativePath = fullPath.fsPath;
if (relativePath.includes('/tests/') || relativePath.includes('\\tests\\')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use path.sep for cross-platform path checks instead of hardcoding '/' and '\'.

Suggested change
if (relativePath.includes('/tests/') || relativePath.includes('\\tests\\')) {
if (relativePath.includes(`${path.sep}tests${path.sep}`)) {

// This is a singular test file, run it as a test instead of a model
this.runDBTModelTest(fullPath);
return;
}

this.runDBTModel(fullPath, type);
}

Expand Down
Loading