feat: Add dbt fusion integration option (#1712) #1723
Conversation
Added support for "fusion" as a dbtIntegration option that uses the cloud CLI integration. This allows users with dbt fusion installed to select it as their integration type. Changes: - Added "fusion" to the dbtIntegration enum in package.json - Updated DBTProject to use cloud integration for fusion mode - Updated DBTClient detection to use cloud detection for fusion - Updated status bar to display "dbt fusion" when fusion is selected - Updated walkthrough commands to use cloud installation for fusion The fusion integration reuses the existing cloud CLI infrastructure since dbt fusion is based on the cloud CLI architecture. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Warning Rate limit exceeded@anandgupta42 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 49 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 3390c4c in 1 minute and 20 seconds. Click for details.
- Reviewed
96lines of code in5files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:109
- Draft comment:
✅ Added 'fusion' to the dbtIntegration enum and updated its description. Looks good. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. src/dbt_client/index.ts:49
- Draft comment:
✅ The DBTClient switch now correctly groups 'fusion' with 'cloud' for detection. This reuse is consistent with current integration. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. src/manifest/dbtProject.ts:134
- Draft comment:
✅ In DBTProject, the integration mode switch now includes 'fusion' to reuse the cloud integration. This is consistent with the feature spec. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. src/statusbar/versionStatusBar.ts:44
- Draft comment:
✅ The getDbtText method now returns 'dbt fusion' for the fusion integration mode, which aligns with the new feature. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. package.json:120
- Draft comment:
Typographical error: The phrase "Python extensions selected interpreter" appears to be missing an apostrophe. It may be clearer as "Python extension's selected interpreter". - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_GKA8hNHlZr6cGvdf
You can customize 
|
|
||
| switch (dbtIntegration) { | ||
| case "cloud": | ||
| case "fusion": |
There was a problem hiding this comment.
👍 The switch in installDbt now handles 'fusion' (using the cloud CLI install) as intended. However, the version comparison (line 254: if (packageVersion >= "1.8")) uses string comparison. Consider using a semver library for reliability.
This comment was generated because it violated a code review rule: irule_2tccYLCrYasDVwB1.
Added support for "fusion" as a dbtIntegration option that uses the cloud CLI integration. This allows users with dbt fusion installed to select it as their integration type.
fix for #1712
Changes:
The fusion integration reuses the existing cloud CLI infrastructure since dbt fusion is based on the cloud CLI architecture.
🤖 Generated with Claude Code
Overview
Problem
Describe the problem you are solving. Mention the ticket/issue if applicable.
Solution
Describe the implemented solution. Add external references if needed.
Screenshot/Demo
A picture is worth a thousand words. Please highlight the changes if applicable.
How to test
Checklist
README.mdupdated and added information about my changeImportant
Add "fusion" as a dbt integration option, using cloud CLI infrastructure for installation and detection.
dbtIntegrationenum inpackage.json.DBTProjectindbtProject.tsto use cloud integration for "fusion" mode.DBTClientinindex.tsto use cloud detection for "fusion".installDbt()inwalkthroughCommands.tsto use cloud installation for "fusion".getDbtText()inversionStatusBar.tsto display "dbt fusion" when fusion is selected.walkthroughCommands.tsto use cloud installation for "fusion".This description was created by
for 3390c4c. You can customize this summary. It will automatically update as commits are pushed.