-
Notifications
You must be signed in to change notification settings - Fork 118
fix: Improve SQL code visibility in light themes (#1719) #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Enhanced the Prism.js light theme colors for better contrast and readability: - Changed base text color from #000 to #24292e for better readability - Updated background from #f5f2f0 to #f6f8fa for cleaner appearance - Improved token colors with higher contrast values: - Keywords: #d73a49 (red) for better visibility - Strings: #032f62 (dark blue) instead of light green - Functions: #6f42c1 (purple) for distinction - Comments: #6a737d (gray) with better contrast - Operators: #22863a (green) without background overlay - Removed text-shadow for cleaner rendering These changes ensure SQL code is clearly visible across all light themes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Warning Rate limit exceeded@anandgupta42 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 7 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 1fd80e8 in 53 seconds. Click for details.
- Reviewed
11
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. query_panel/assets/prism-light.css:1
- Draft comment:
The updated CSS improves readability in light themes by using a new base text color (#24292e), a modified background (#f6f8fa), and adjusted token colors (e.g., keywords to #d73a49, strings to #032f62, functions to #6f42c1, comments to #6a737d). The removal of the text-shadow is clear and intentional. As a maintenance tip, consider abstracting these repeated color values into CSS variables so that future theme adjustments become easier. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_W3Bz07ANlTWcniHg
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
fix for #1719
Enhanced the Prism.js light theme colors for better contrast and readability:
These changes ensure SQL code is clearly visible across all light themes.
🤖 Generated with Claude Code
Overview
Problem
Describe the problem you are solving. Mention the ticket/issue if applicable.
Solution
Describe the implemented solution. Add external references if needed.
Screenshot/Demo
A picture is worth a thousand words. Please highlight the changes if applicable.
How to test
Checklist
README.md
updated and added information about my changeImportant
Improves SQL code visibility in light themes by adjusting colors in
prism-light.css
.prism-light.css
:#000
to#24292e
for better readability.#f5f2f0
to#f6f8fa
.#d73a49
(red) for better visibility.#032f62
(dark blue) instead of light green.#6f42c1
(purple) for distinction.#6a737d
(gray) with better contrast.#22863a
(green) without background overlay.This description was created by
for 1fd80e8. You can customize this summary. It will automatically update as commits are pushed.