Skip to content

fix: Improve SQL code visibility in light themes (#1719) #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anandgupta42
Copy link
Contributor

@anandgupta42 anandgupta42 commented Jul 20, 2025

fix for #1719
Enhanced the Prism.js light theme colors for better contrast and readability:

  • Changed base text color from #000 to #24292e for better readability
  • Updated background from #f5f2f0 to #f6f8fa for cleaner appearance
  • Improved token colors with higher contrast values:
    • Keywords: #d73a49 (red) for better visibility
    • Strings: #032f62 (dark blue) instead of light green
    • Functions: #6f42c1 (purple) for distinction
    • Comments: #6a737d (gray) with better contrast
    • Operators: #22863a (green) without background overlay
  • Removed text-shadow for cleaner rendering

These changes ensure SQL code is clearly visible across all light themes.

🤖 Generated with Claude Code

Overview

Problem

Describe the problem you are solving. Mention the ticket/issue if applicable.

Solution

Describe the implemented solution. Add external references if needed.

Screenshot/Demo

A picture is worth a thousand words. Please highlight the changes if applicable.

How to test

  • Steps to be followed to verify the solution or code changes
  • Mention if there is any settings configuration added/changed/deleted

Checklist

  • I have run this code and it appears to resolve the stated issue
  • README.md updated and added information about my change

Important

Improves SQL code visibility in light themes by adjusting colors in prism-light.css.

  • CSS Changes in prism-light.css:
    • Base text color changed from #000 to #24292e for better readability.
    • Background color updated from #f5f2f0 to #f6f8fa.
    • Removed text-shadow for cleaner rendering.
    • Token color adjustments:
      • Keywords: #d73a49 (red) for better visibility.
      • Strings: #032f62 (dark blue) instead of light green.
      • Functions: #6f42c1 (purple) for distinction.
      • Comments: #6a737d (gray) with better contrast.
      • Operators: #22863a (green) without background overlay.

This description was created by Ellipsis for 1fd80e8. You can customize this summary. It will automatically update as commits are pushed.

Enhanced the Prism.js light theme colors for better contrast and readability:
- Changed base text color from #000 to #24292e for better readability
- Updated background from #f5f2f0 to #f6f8fa for cleaner appearance
- Improved token colors with higher contrast values:
  - Keywords: #d73a49 (red) for better visibility
  - Strings: #032f62 (dark blue) instead of light green
  - Functions: #6f42c1 (purple) for distinction
  - Comments: #6a737d (gray) with better contrast
  - Operators: #22863a (green) without background overlay
- Removed text-shadow for cleaner rendering

These changes ensure SQL code is clearly visible across all light themes.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link
Contributor

coderabbitai bot commented Jul 20, 2025

Warning

Rate limit exceeded

@anandgupta42 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 7 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9b02f74 and 1fd80e8.

📒 Files selected for processing (1)
  • query_panel/assets/prism-light.css (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 1fd80e8 in 53 seconds. Click for details.
  • Reviewed 11 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. query_panel/assets/prism-light.css:1
  • Draft comment:
    The updated CSS improves readability in light themes by using a new base text color (#24292e), a modified background (#f6f8fa), and adjusted token colors (e.g., keywords to #d73a49, strings to #032f62, functions to #6f42c1, comments to #6a737d). The removal of the text-shadow is clear and intentional. As a maintenance tip, consider abstracting these repeated color values into CSS variables so that future theme adjustments become easier.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_W3Bz07ANlTWcniHg

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant