Skip to content

Fix export partition ordering unit test #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enmk merged 2 commits into from
Nov 20, 2025
Merged

Fix export partition ordering unit test #1157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08c5c1c
Add transaction_id to partition manifests in tests
arthurpassos Nov 20, 2025
3707112
Fix transaction_id assignment in export partition tests
arthurpassos Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Storages/MergeTree/tests/gtest_export_partition_ordering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,21 @@ TEST_F(ExportPartitionOrderingTest, IterationOrderMatchesCreateTime)
manifest1.partition_id = "2020";
manifest1.destination_database = "db1";
manifest1.destination_table = "table1";
manifest1.transaction_id = "tx1";
Copy link

@ianton-ru ianton-ru Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right that problem was that all manifests got same (empty) transaction_id?

Copy link
Collaborator Author

@arthurpassos arthurpassos Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because one of my latest changes was adding an unique index for transaction_id. See

ClickHouse/src/Storages/ExportReplicatedMergeTreePartitionTaskEntry.h

Line 71 in d09fb0b

boost::multi_index::hashed_unique<
.

That caused the entries to be replaced

manifest1.create_time = base_time + 300; // Latest

ExportReplicatedMergeTreePartitionManifest manifest2;
manifest2.partition_id = "2021";
manifest2.destination_database = "db1";
manifest2.destination_table = "table1";
manifest2.transaction_id = "tx2";
manifest2.create_time = base_time + 100; // Middle

ExportReplicatedMergeTreePartitionManifest manifest3;
manifest3.partition_id = "2022";
manifest3.destination_database = "db1";
manifest3.destination_table = "table1";
manifest3.transaction_id = "tx3";
manifest3.create_time = base_time; // Oldest

ExportReplicatedMergeTreePartitionTaskEntry entry1{manifest1, ExportReplicatedMergeTreePartitionTaskEntry::Status::PENDING, {}};
Expand Down
Loading