Conversation
…to avoid all assumeMutable calls, simplify the substreams cache, and remove rows_offset
…hed Processor Removal"
…efore logging exceptions
…r freshly supplied definitions
…5396 Backport ClickHouse#115396 to 26.8: Complete ZooKeeper finalization before logging exceptions
…ection_settings_replicated
…6153 Backport ClickHouse#116153 to 26.8: Validate the Alias target only for freshly supplied definitions
…jemalloc errors and add entry about disabled per-cpu arena into system.warnings
…7365 Backport ClickHouse#117365 to 26.8: Fix flaky 04758_alter_modify_projection_settings_replicated
`settingGetTier` in `resolveSetting.h` calls `T::tryGetTierOfBuiltin`. It was added to `BaseSettings` and `Settings` on master after 26.8 was cut, so the backport did not build.
…6899 Backport ClickHouse#116899 to 26.8: Ignore only well known and minor jemalloc errors and add entry about disabled per-cpu arena into system.warnings
…6223 Backport ClickHouse#116223 to 26.8: Fix `role_arn` S3 incremental backup chains
…3156 Backport ClickHouse#113156 to 26.8: Fix allow_feature_tier for MergeTree settings
…1427 Backport ClickHouse#111427 to 26.8: Refactor columns deserialization to avoid all assumeMutable calls, simplify the substreams cache, and remove rows_offset
… Tuple subcolumn of Dynamic or Variant from a part
They assert AI ProfileEvents on ExceptionWhileProcessing rows, a master-only behavior absent on 26.8 (api_calls reads 0), and are unrelated to ClickHouse#116227. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…6739 Backport ClickHouse#116739 to 26.8: Fix logical error reading a whole Tuple subcolumn of Dynamic or Variant from a part
…6227 Backport ClickHouse#116227 to 26.8: Move AI functions to Beta
…nchronous metrics back to their old names
…7128 Backport ClickHouse#117128 to 26.8: Revert "Print Pipeline on Unfinished Processor Removal"
…6791 Backport ClickHouse#116791 to 26.8: Allow switching the key-value asynchronous metrics back to their old names
…N set with ARRAY JOIN
…t serialization of JSON and Dynamic columns
…f` and `sumKahan` over `Nullable` when the aggregated batch does not start at row 0
…lumn value coming from MySQL
…ase pointing at a removed directory, which makes the server refuse to start
…9680 Backport ClickHouse#119680 to 26.8: Validate the length of a `BIT` column value coming from MySQL
…9618 Backport ClickHouse#119618 to 26.8: Do not leave a `Filesystem` database pointing at a removed directory, which makes the server refuse to start
`hasSecretsInStep` was cherry-picked with a branch for `ArrayJoinStep::getElementFilter`, which only exists on `master` where the fuse-filter pass can push a filter into the array join, so the build failed with `no member named 'getElementFilter' in 'DB::ArrayJoinStep'`. In this branch `ArrayJoinStep` carries no `ActionsDAG` at all, so it cannot hold a secret and the branch has nothing to check: drop it together with the include.
`test_writes_manifest_list_partition_summary` asserts the raw bytes of the manifest-list partition summary, and it is the first test to do so, which is why it fails on this branch for every parametrisation while it is green on master: At index 1 diff: (False, None, b'\x0b\x00\x00\x00\x00\x00\x00\x00', ...) != (False, None, b'\x0b\x00\x00\x00', ...) The `Int32` partition bound is written as 8 bytes where Appendix D of the Iceberg specification requires 4. `dumpValue` sizes its output as `sizeof(T)` with `T` deduced from its argument, and `Field::safeGet<Int32>` returns `NearestFieldType<Int32>`, which is `Int64`, so the branch asks for an `Int32` and gets an 8-byte value. Narrow before `dumpValue` sees it, with the same `static_cast<Int32>` the neighbouring small-integer branch already uses. This is the source half of `3dc6b4f4ef32` (ClickHouse#117571, `Closes ClickHouse#117072`), which never got a backport label; this branch needs it because the test it adds pins the spec width. That test is the coverage here, so the stateless test of the original commit is left out rather than duplicated. The data-file bounds are corrected by the same line, so this branch stops writing manifests that `pyiceberg` refuses to plan a filtered scan over (`unpack requires a buffer of 4 bytes`). No reader change is needed in either direction: `ColumnVector::insertData` ignores the buffer length and does `unalignedLoad<T>(pos)`, so an existing 8-byte bound still decodes. Related: ClickHouse#117571 Related: ClickHouse#117072
The `Integration tests (amd_asan_ubsan, db disk, old analyzer, 4/6)`
job produced no result at all:
Job failed to produce Result due to a script error or CI runner issue
The job log shows the shard going silent for 61 minutes right after
`test_zero_copy_drop_table_with_leftover/test.py::test_drop_database_with_leftover_part`
at 88%, then praktika's 7800 s wall clock sending `SIGTERM` before
pytest could write a result. Eight unrelated 26.8 backports wedged at
the same point in the same window, and that shard has been green for
every 26.8 backport since, so this is the runner, not the change: the
only C++ line here adds `HTTP_CONFLICT` to the *non*-retriable set,
which removes retries and is unrelated to zero-copy tests.
Taking 26.8 both refreshes the three-day-old branch and re-triggers
the workflow.
…8129 Backport ClickHouse#118129 to 26.8: Fix secret bug in explain
…8796 Backport ClickHouse#118796 to 26.8: Iceberg manifest list partition summaries
…hen `trim(BOTH '' FROM x)` is used where a function is expected
…9238 Backport ClickHouse#119238 to 26.8: Don't use backoffs on concurrent inserts conflicts
…9317 Backport ClickHouse#119317 to 26.8: Fix a crash and a LOGICAL_ERROR when `trim(BOTH '' FROM x)` is used where a function is expected
…le subcolumn of a Variant or Dynamic column
…2338 Backport ClickHouse#112338 to 26.8: Fix a crash when reading a nullable subcolumn of a Variant or Dynamic column
…onnection by its descriptor during shutdown
…ead-ahead after its own timeout fallback
…lightweight updates when a sorting key column has a DEFAULT
…9450 Backport ClickHouse#119450 to 26.8: Keeper: interrupt a stalled TLS connection by its descriptor during shutdown
…9627 Backport ClickHouse#119627 to 26.8: Keeper: do not reset the commit read-ahead after its own timeout fallback
…9540 Backport ClickHouse#119540 to 26.8: Fix a crash reading a table with lightweight updates when a sorting key column has a DEFAULT
…chains into `multiMatchAny`
Release v26.8.3.105-lts
…8766 Backport ClickHouse#118766 to 26.8: Do not rewrite end-anchored LIKE chains into `multiMatchAny`
Release v26.8.4.11-lts
strtgbb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
CI/CD Options
Exclude tests:
Regression jobs to run: