gcs: mitigate transient errors causing corruption #1293
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For long backups, there appears to be a relatively high chance of random issue like a 503. When these issues, it appears that the clickhouse-backup retries are not sufficient, as we are seeing missing table parts get reported. This is a mitigation because in theory, the wrapping retries would correctly retry these issues, however it does not appear to be the case. More understanding is needed to fix that particular issue.
Collaborator
|
@devoxel could you merge latest master to your branch, need to pass CI/CD |
Collaborator
|
ok. let's wait when CI/CD finish |
Pull Request Test Coverage Report for Build 19457919467Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1291
This does not totally fix the problem, as it may be present in other impelmentations. Also #1292 needs to be fixed the help users who do not set the
chunk_sizeoption