fix: correctly delete existing helm release artifacts by appending asset ID to URL #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D to URL Co-authored-by: aider (openrouter/x-ai/grok-code-fast-1) <[email protected]>
Slach
commented
Sep 26, 2025
| if: steps.get_assets.outputs.asset_id != '' | ||
| run: | | ||
| curl -X DELETE -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \ | ||
| "https://api.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets/${{ steps.get_assets.outputs.asset_id }}" |
Collaborator
Author
There was a problem hiding this comment.
i really happy we found it
Member
There was a problem hiding this comment.
Well, the level of this token access does not allow to delete repo, but thanks anyway
alex-zaitsev
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oh, looks like we always failed to second "release published" event
look logs https://github.com/Altinity/clickhouse-operator/actions/workflows/release_chart.yaml, and it was really dangerous cause trying delete whole repo...
only quote " prevented us from failure
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info