Helm: add metrics.enabled conditional checks for serviceMonitor #1834
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slach
requested changes
Sep 30, 2025
Collaborator
Slach
left a comment
Slach
left a comment
There was a problem hiding this comment.
templates/generated
Shall be changed not directly, but via generate_helm_chart.sh
look details
https://github.com/Altinity/clickhouse-operator/blob/master/dev/generate_helm_chart.sh
Signed-off-by: KJone1 <[email protected]>
Contributor
Author
|
@Slach fixed. updated the script instead |
Slach
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1831
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info