fix: add chi-/chk- prefixes to PDB names to prevent naming conflicts

[karnzx]

Problem

When both ClickHouse Installation (CHI) and ClickHouse Keeper (CHK) resources are deployed in the same namespace with the same name, their PodDisruptionBudgets (PDBs) will have identical names, causing one PDB to be replaced by the other. This results in only one PDB being created instead of two separate PDBs for each resource type.

Root Cause

The current implementation creates PDB names using only the custom resource name without any prefix:

  ObjectMeta: meta.ObjectMeta{
   Name:            c.nm.Name(interfaces.NameClusterPDB, cluster),
   ...
  },

Solution

Add the chi- and chk- prefix to custom resource PDB names to match the existing pattern used in PDB creation and ensure unique naming across resource types.

Impact Assessment

• Very Low Risk: This is a non-breaking change that only affects PDB naming
• No Breaking Changes: Existing deployments will continue to work; only new PDBs will have the prefix
• Backward Compatibility: Existing PDBs with and without prefixes will continue to function normally
• Consistency: Aligns PDB naming with the existing naming pattern

Example

Before the fix:

• CHI resource named "my-cluster" → PDB name: "my-cluster"
• CHK resource named "my-cluster" → PDB name: "my-cluster" (conflict!)

After the fix:

• CHI resource named "my-cluster" → PDB name: "chi-my-cluster-"
• CHK resource named "my-cluster" → PDB name: "chk-my-cluster" (no conflict!)

This ensures both PDBs can coexist in the same namespace without naming conflicts.

[alex-zaitsev]

@karnzx , that has been fixed in 0.25.3. Are you using the latest version? The naming patterns for PDBs is the following now:
[chk|chi]-{name}-{cluster}

[sunsingerus]

fixed in release 0.25.3