Skip to content

Conversation

@Slach
Copy link
Collaborator

@Slach Slach commented Oct 7, 2025

python3 ./tests/regression.py --native --no-color --only="/regression/e2e.test_keeper/test_zookeeper_manual_teardown_rescale*"

passed locally

 [ OK ] /regression/e2e.test_keeper/test_zookeeper_manual_teardown_rescale. Check ZK+Manual TEARDOWN scale-up ∕ scale-down cases (26m 16s)

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

alex-zaitsev
alex-zaitsev previously approved these changes Oct 7, 2025
@alex-zaitsev
Copy link
Member

alex-zaitsev commented Oct 7, 2025

Failed basic tests:
✘ [ Fail ] /regression/e2e.test_operator/test_010010. Test zookeeper initialization (3s 146ms)

    File "/home/runner/work/clickhouse-operator/clickhouse-operator/tests/e2e/test_operator.py", line 620, in test_010010
      util.require_keeper(keeper_type=self.context.keeper_type)
    File "/home/runner/work/clickhouse-operator/clickhouse-operator/tests/e2e/util.py", line 115, in require_keeper
      docs_count == expected_docs[keeper_type]
  AssertionError: invalid zookeeper manifest, expected 6, actual 4 documents in ../../deploy/zookeeper/zookeeper-manually/quick-start-persistent-volume/zookeeper-1-node-1GB-for-tests-only.yaml file

@alex-zaitsev alex-zaitsev dismissed their stale review October 7, 2025 10:25

failed tests

@Slach
Copy link
Collaborator Author

Slach commented Oct 7, 2025

@alex-zaitsev but test was passed

image

@Slach
Copy link
Collaborator Author

Slach commented Oct 7, 2025

@alex-zaitsev shall be fixed in e57c370

@alex-zaitsev
Copy link
Member

continue-on-error is true for reason. There is a logic to detect failed tests, but for some reason it does not always work. I will fix manually.

@alex-zaitsev alex-zaitsev self-requested a review October 13, 2025 05:42
@alex-zaitsev alex-zaitsev merged commit 5d7bf0b into 0.25.5 Oct 13, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants