Feature/remilovoll/26/03/movepolicyfilemigrating#2603
Conversation
1. when moving instance delegation 2. in app instance delegation in existinf api
There was a problem hiding this comment.
Pull request overview
This PR introduces feature-flagged support for a new instance-delegation policy file path format (intended for an EF-backed storage layout) and adds logic to move/copy existing policy blobs to the new location during instance assignment import.
Changes:
- Add
AccessManagement.InstanceDelegation.EFfeature flag branching to select “old” vs “new” instance delegation policy paths. - Update instance assignment import flow to copy policy blobs to a new path using blob leases, and extend APIs/call sites with
partyId. - Update constructors/tests to inject
IFeatureManagerand add a new helper for the EF path format.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/apps/Altinn.AccessManagement/test/AccessMgmt.Tests/PolicyAdministrationPointTest.cs | Updates test wiring for new PolicyAdministrationPoint constructor dependency (IFeatureManager). |
| src/apps/Altinn.AccessManagement/src/Altinn.AccessMgmt.Core/Utils/Helper/DelegationCheckHelper.cs | Treats a new “missing original policy file” error as eligible for error-queue handling. |
| src/apps/Altinn.AccessManagement/src/Altinn.AccessMgmt.Core/Services/Contracts/IAssignmentService.cs | Extends ImportInstanceAssignmentChange API with fromPartyId. |
| src/apps/Altinn.AccessManagement/src/Altinn.AccessMgmt.Core/Services/AssignmentService.cs | Adds blob-copy + lease logic for moving instance policy files to a new location. |
| src/apps/Altinn.AccessManagement/src/Altinn.AccessMgmt.Core/HostedServices/Services/SingleInstanceRightSyncService.cs | Passes partyId into ImportInstanceAssignmentChange. |
| src/apps/Altinn.AccessManagement/src/Altinn.AccessManagement.Core/Services/PolicyAdministrationPoint.cs | Adds feature-flag routing to choose old/new instance policy paths. |
| src/apps/Altinn.AccessManagement/src/Altinn.AccessManagement.Core/Services/AppsInstanceDelegationService.cs | Adds feature-flag handling and party lookups to construct an internal instance URN. |
| src/apps/Altinn.AccessManagement/src/Altinn.AccessManagement.Core/Helpers/DelegationHelper.cs | Adds TryGetNewDelegationPolicyPathFromInstanceRule for the new EF path format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
src/apps/Altinn.AccessManagement/src/Altinn.AccessMgmt.Core/Services/AssignmentService.cs
Show resolved
Hide resolved
src/apps/Altinn.AccessManagement/src/Altinn.AccessMgmt.Core/Services/AssignmentService.cs
Outdated
Show resolved
Hide resolved
src/apps/Altinn.AccessManagement/src/Altinn.AccessMgmt.Core/Services/AssignmentService.cs
Outdated
Show resolved
Hide resolved
....AccessManagement/src/Altinn.AccessManagement.Core/Services/AppsInstanceDelegationService.cs
Outdated
Show resolved
Hide resolved
...tinn.AccessManagement/src/Altinn.AccessManagement.Core/Services/PolicyAdministrationPoint.cs
Show resolved
Hide resolved
src/apps/Altinn.AccessManagement/src/Altinn.AccessMgmt.Core/Services/AssignmentService.cs
Show resolved
Hide resolved
....AccessManagement/src/Altinn.AccessManagement.Core/Services/AppsInstanceDelegationService.cs
Show resolved
Hide resolved
.../Altinn.AccessManagement/src/Altinn.AccessMgmt.Core/Services/Contracts/IAssignmentService.cs
Outdated
Show resolved
Hide resolved
....AccessManagement/src/Altinn.AccessManagement.Core/Services/AppsInstanceDelegationService.cs
Outdated
Show resolved
Hide resolved
src/apps/Altinn.AccessManagement/src/Altinn.AccessManagement.Core/Helpers/DelegationHelper.cs
Outdated
Show resolved
Hide resolved
jonkjetiloye
left a comment
There was a problem hiding this comment.
Litt småpirk fra copilot du kan vurdere.
Ellers ser det bra ut
|




Description
Related Issue(s)
Verification
Documentation