Skip to content

bug/accmgmt-request-link-fix #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thuen merged 4 commits into from
Mar 24, 2026
Merged

bug/accmgmt-request-link-fix #2604

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25f9d1f
Update RequestController.cs
Thuen Mar 19, 2026
e0f4617
Update RequestController.cs
Thuen Mar 23, 2026
bdd63de
Merge branch 'main' into bug/accmgmt-request-links
Thuen Mar 23, 2026
d2b5467
Update RequestController.cs
Thuen Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ...sManagement/src/Altinn.AccessManagement.Api.ServiceOwner/Controllers/RequestController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System.ComponentModel.DataAnnotations;
using System.Net.Mime;
using Altinn.AccessManagement.Api.ServiceOwner.Validation;
using Altinn.AccessManagement.Core.Configuration;
using Altinn.AccessManagement.Core.Constants;
using Altinn.AccessManagement.Core.Errors;
using Altinn.AccessMgmt.Core;
Expand All @@ -13,6 +14,7 @@
using Altinn.Authorization.ProblemDetails;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Options;
using Microsoft.FeatureManagement;
using Microsoft.FeatureManagement.Mvc;

Expand All @@ -27,9 +29,13 @@
IRequestService requestService,
IEntityService entityService,
IResourceService resourceService,
IAuditAccessor auditAccessor
IAuditAccessor auditAccessor,
IOptions<GeneralSettings> generalSettings
) : ControllerBase
{

Check warning on line 35 in src/apps/Altinn.AccessManagement/src/Altinn.AccessManagement.Api.ServiceOwner/Controllers/RequestController.cs

View check run for this annotation

SonarQubeCloud / [Authorization Altinn.AccessManagement] SonarCloud Code Analysis

An opening brace should not be followed by a blank line 


See more on https://sonarcloud.io/project/issues?id=Authorization_AccessManagement&issues=AZ0ethWCoNdODzBrVyns&open=AZ0ethWCoNdODzBrVyns&pullRequest=2604

private readonly GeneralSettings _generalSettings = generalSettings.Value;

/// <summary>
/// Get valid urn prefixes for party identification
/// </summary>
Expand Down Expand Up @@ -363,9 +369,9 @@

private static string[] ValidUrns => ["urn:altinn:person:identifier-no", "urn:altinn:organization:identifier-no"];

private static RequestLinks BuildLinks(Guid requestId) => new()
private RequestLinks BuildLinks(Guid requestId) => new()
{
DetailsLink = $"accessmanagement/api/v1/enduser/request/{requestId}/accept",
StatusLink = $"accessmanagement/api/v1/serviceowner/delegationrequests/{requestId}"
DetailsLink = $"https://am.ui.{_generalSettings.Hostname}/accessmanagement/ui/requests/resource?requestId={requestId}",
StatusLink = $"https://platform.{_generalSettings.Hostname}/accessmanagement/api/v1/serviceowner/delegationrequests/{requestId}/status"
};
}
Loading