Conversation
added 3 commits
March 20, 2026 09:33
Fix Prefix validering av PartyUrn Fix instance to only look at the last part for comparison
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AccessManagement instance-delegation flow to better support instance-based delegation checks from apps/enduser connections by extending test data and adding a Bruno request, while adjusting backend lookup/validation behavior for instance delegations.
Changes:
- Extend Bruno testdata with
instanceResourceIdand a concreteinstances.testInstance1in multiple environments. - Add a new Bruno “Instances” folder and POST request that exercises instance-scoped rights creation.
- Adjust instance delegation lookup/validation in persistence and core services (instance-id matching, from-party consistency validation, PartyUrn parsing fix).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/apps/Altinn.AccessManagement/test/Bruno/AccessMgmt/testdata/resource-delegationcheck/tt02.js | Adds instance resource id + test instance urn used by Bruno tests. |
| src/apps/Altinn.AccessManagement/test/Bruno/AccessMgmt/testdata/resource-delegationcheck/at22.js | Adds instance resource id + test instance urn used by Bruno tests. |
| src/apps/Altinn.AccessManagement/test/Bruno/AccessMgmt/test/EnduserAPI/Connections/Resources/AddActions/Post_Enduser_Conn_Resources_Dagl.bru | Fixes requestName to match the request file. |
| src/apps/Altinn.AccessManagement/test/Bruno/AccessMgmt/test/EnduserAPI/Connections/Instances/folder.bru | Adds Bruno folder metadata for the new Instances group. |
| src/apps/Altinn.AccessManagement/test/Bruno/AccessMgmt/test/EnduserAPI/Connections/Instances/Post_Enduser_Conn_Instances_Dagl.bru | Adds a Bruno request covering instance-scoped rights. |
| src/apps/Altinn.AccessManagement/src/Altinn.AccessManagement.Persistence/DelegationMetadataEF.cs | Changes EF filtering for instance delegations to use suffix matching. |
| src/apps/Altinn.AccessManagement/src/Altinn.AccessManagement.Core/Services/PolicyInformationPoint.cs | Adds validation to detect multiple “from” parties for a single instance delegation lookup. |
| src/apps/Altinn.AccessManagement/src/Altinn.AccessManagement.Core/Services/AppsInstanceDelegationService.cs | Fixes PartyUrn parsing switch and maps validation exceptions from PIP to InvalidInstanceId errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...apps/Altinn.AccessManagement/src/Altinn.AccessManagement.Persistence/DelegationMetadataEF.cs
Show resolved
Hide resolved
.../Altinn.AccessManagement/src/Altinn.AccessManagement.Core/Services/PolicyInformationPoint.cs
Outdated
Show resolved
Hide resolved
.../Bruno/AccessMgmt/test/EnduserAPI/Connections/Instances/Post_Enduser_Conn_Instances_Dagl.bru
Outdated
Show resolved
Hide resolved
…rsing policy files as this is unnesesery when failing and is expencive to perform.
…duserAPI/Connections/Instances/Post_Enduser_Conn_Instances_Dagl.bru Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…mApp' of https://github.com/Altinn/altinn-authorization-tmp into feature/remilovoll/26/03/BugFixingInstanceDelegationFromApp
|
|
jonkjetiloye
approved these changes
Mar 20, 2026
lovoll
deleted the
feature/remilovoll/26/03/BugFixingInstanceDelegationFromApp
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation