⚠️ remove AllowSystemDeleteAfter from the database

Test/Altinn.Correspondence.LoadTests.DatabasePopulater/DatabasePopulator.cs

@@ -116,7 +116,7 @@ public List<string> PopulateWithCorrespondences(int totalCount)
             },
             "\"correspondence\".\"Correspondences\"",
             @"Id, ResourceId, Recipient, Sender, SendersReference, MessageSender,
-              RequestedPublishTime, AllowSystemDeleteAfter, DueDateTime, PropertyList,
+              RequestedPublishTime, DueDateTime, PropertyList,
               IgnoreReservation, Created, Altinn2CorrespondenceId, Published, IsConfirmationNeeded"
         );
     }

Test/Altinn.Correspondence.LoadTests.DatabasePopulater/generate_test_data_function.sql

@@ -42,7 +42,6 @@ begin
             "SendersReference",
             "MessageSender",
             "RequestedPublishTime",
-            "AllowSystemDeleteAfter",
             "DueDateTime",
             "PropertyList",
             "IgnoreReservation",

Test/Altinn.Correspondence.Tests/TestingHandler/CleanupPerishingDialogsHandlerTests.cs

@@ -32,7 +32,7 @@ public async Task ExecuteCleanupInBackground_RemovesExpiresAtAndCountsAlreadyOk(
         repo.SetupSequence(r => r.GetCorrespondencesWindowAfter(It.IsAny<int>(), It.IsAny<DateTimeOffset?>(), It.IsAny<Guid?>(), true, It.IsAny<CancellationToken>()))
             .ReturnsAsync(new List<CorrespondenceEntity> { c1, c2 })
             .ReturnsAsync(new List<CorrespondenceEntity>());
-        repo.Setup(r => r.GetCorrespondencesByIdsWithExternalReferenceAndAllowSystemDeleteAfter(
+        repo.Setup(r => r.GetCorrespondencesByIdsWithExternalReference(
                 It.IsAny<List<Guid>>(),
                 It.IsAny<ReferenceType>(),
                 It.IsAny<CancellationToken>()))
@@ -84,7 +84,7 @@ public async Task ExecuteCleanupInBackground_DoesNotReprocessOrSkipItemsBetweenB
                     .ToList();
                 return query;
             });
-        repo.Setup(r => r.GetCorrespondencesByIdsWithExternalReferenceAndAllowSystemDeleteAfter(
+        repo.Setup(r => r.GetCorrespondencesByIdsWithExternalReference(
                 It.IsAny<List<Guid>>(),
                 It.IsAny<ReferenceType>(),
                 It.IsAny<CancellationToken>()))

src/Altinn.Correspondence.API/Controllers/MaintenanceController.cs

@@ -49,7 +49,7 @@ public async Task<ActionResult> CleanupOrphanedDialogs(
     }
 
     /// <summary>
-    /// Enqueue cleanup to remove expiresAt from dialogs in Dialogporten for correspondences where AllowSystemDeleteAfter has been set
+    /// Enqueue cleanup to remove expiresAt from dialogs in Dialogporten
     /// </summary>
     /// <response code="200">Returns the enqueued job id</response>
     /// <response code="401">Unauthorized</response>

src/Altinn.Correspondence.Application/CleanupPerishingDialogs/CleanupPerishingDialogsHandler.cs

@@ -73,7 +73,7 @@ public async Task ExecuteCleanupInBackground(int windowSize, CancellationToken c
                 }
 
                 var windowIds = correspondencesWindow.Select(c => c.Id).ToList();
-                var candidates = await correspondenceRepository.GetCorrespondencesByIdsWithExternalReferenceAndAllowSystemDeleteAfter(
+                var candidates = await correspondenceRepository.GetCorrespondencesByIdsWithExternalReference(
                     windowIds,
                     ReferenceType.DialogportenDialogId,
                     cancellationToken);

src/Altinn.Correspondence.Core/Models/Entities/CorrespondenceEntity.cs

@@ -42,8 +42,6 @@ public class CorrespondenceEntity
 
         public required DateTimeOffset RequestedPublishTime { get; set; }
 
-        public DateTimeOffset? AllowSystemDeleteAfter { get; set; }
-
         public DateTimeOffset? DueDateTime { get; set; }
 
         public List<ExternalReferenceEntity> ExternalReferences { get; set; } = new List<ExternalReferenceEntity>();

src/Altinn.Correspondence.Core/Repositories/ICorrespondenceRepostitory.cs

@@ -84,7 +84,7 @@ Task<List<CorrespondenceEntity>> GetCorrespondencesByIdsWithExternalReferenceAnd
             List<CorrespondenceStatus> excludedCurrentStatuses,
             CancellationToken cancellationToken);
 
-        Task<List<CorrespondenceEntity>> GetCorrespondencesByIdsWithExternalReferenceAndAllowSystemDeleteAfter(
+        Task<List<CorrespondenceEntity>> GetCorrespondencesByIdsWithExternalReference(
             List<Guid> correspondenceIds,
             ReferenceType referenceType,
             CancellationToken cancellationToken);