Fix Party not being set in Dialog for Synced Read and Confirm events#1721
Merged
RagnarFatland merged 3 commits intomainfrom Feb 10, 2026
Merged
Fix Party not being set in Dialog for Synced Read and Confirm events#1721RagnarFatland merged 3 commits intomainfrom
RagnarFatland merged 3 commits intomainfrom
Conversation
…ogporten when creating InformationActivities for both Read and Confirmed. Since this was not sent earlier, this could lead to cases where it is incorrectly reported that the recipient performed the action, when it could be other people og end user systems.
Contributor
📝 WalkthroughWalkthroughThe pull request introduces multi-user testing support by adding a second test user to the Altinn Register test service, refactoring test cases to validate party URN handling in Dialogporten activity enqueuing, and adding runtime guards in the production handler to verify end-user mappings before processing status events. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
RagnarFatland
commented
Feb 5, 2026
...n.Correspondence.Application/SyncCorrespondenceEvent/SyncCorrespondenceStatusEventHandler.cs
Show resolved
Hide resolved
RagnarFatland
commented
Feb 5, 2026
...n.Correspondence.Application/SyncCorrespondenceEvent/SyncCorrespondenceStatusEventHandler.cs
Show resolved
Hide resolved
Ceredron
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated SyncCorrespondenceStatusEventsHandler to send partyurn/actorid to Dialgporten when creating InformationActivities for both Read and Confirmed.
Since this was not sent earlier, this could lead to cases where it is incorrectly reported that the recipient performed the action, when it could be other people or end user systems.
Description
Also added unit tests and data to validate behavior.
Related Issue(s)
Verification
Documentation
Summary by CodeRabbit
Bug Fixes
Tests