Skip to content

Set tags directly on resource#1723

Open
axely123 wants to merge 6 commits intomainfrom
chore/fix-missing-finops-tags
Open

Set tags directly on resource#1723
axely123 wants to merge 6 commits intomainfrom
chore/fix-missing-finops-tags

Conversation

@axely123
Copy link
Collaborator

@axely123 axely123 commented Feb 5, 2026

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green
  • If pre- or post-deploy actions (including database migrations) are needed, add a description, include a "Pre/Post-deploy actions" section below, and mark the PR title with ⚠️

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

  • Chores
    • Redis instances now automatically inherit resource group tags to ensure consistent tagging across resources.
    • Service-owner resource group tagging enhanced to populate a richer, case-insensitive set of tags for better organization and tracking of related resources.

@axely123 axely123 self-assigned this Feb 5, 2026
@axely123 axely123 added the kind/chore changes that do not relate to a fix or feature and don't modify src or test files label Feb 5, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

Adds propagation of resource group tags to the Redis Bicep module and centralizes service-owner resource group tag assembly in AzureResourceManagerService via a new helper and related constants; logging placeholder and tag assignment logic were adjusted accordingly.

Changes

Cohort / File(s) Summary
Redis Infrastructure
.azure/modules/redis/main.bicep
Adds a tags property to the Redis resource, set to resourceGroup().tags to propagate resource group tags.
Service Owner Tagging
src/Altinn.Correspondence.Integrations/Azure/AzureResourceManagerService.cs
Adds FinopsProduct and RepositoryUrl constants; introduces GetServiceOwnerResourceGroupTags to build a case-insensitive tag dictionary; replaces direct tag addition with looped assignment from the helper; updates a log message to use a named placeholder.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description lacks substantive content; it only contains template placeholders with no actual implementation details, rationale, or explanation of changes. Fill in the Description section with details about the changes, explain why tags are being set directly on resources, and confirm verification checklist items have been completed.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Set tags directly on resource' accurately summarizes the main change: adding tags to the Redis resource and implementing a comprehensive tagging system in the Azure resource manager service.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/fix-missing-finops-tags

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/chore changes that do not relate to a fix or feature and don't modify src or test files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant