Open
Conversation
kpanot
force-pushed
the
feature/analytics
branch
2 times, most recently
from
358291c to
584122e
Compare
Contributor
|
View your CI Pipeline Execution ↗ for commit e4af13b.
☁️ Nx Cloud last updated this comment at |
github-actions
bot
added
enhancement
kpanot
force-pushed
the
feature/analytics
branch
from
7aaa320 to
cbc141a
Compare
kpanot
force-pushed
the
feature/analytics
branch
2 times, most recently
from
83d6847 to
c2d7f28
Compare
kpanot
force-pushed
the
feature/analytics
branch
from
c2d7f28 to
d1ebcca
Compare
kpanot
force-pushed
the
feature/analytics
branch
4 times, most recently
from
843054d to
44f54ae
Compare
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kpanot
force-pushed
the
feature/analytics
branch
3 times, most recently
from
055d1be to
3dae4b0
Compare
cpaulve-1A
reviewed
Jan 20, 2025
cpaulve-1A
reviewed
Jan 20, 2025
|
|
||
| The time to interactive is quite tricky as it not only depends on the relevant data readiness, but also on | ||
| component internal display mechanics. | ||
| If you know exactly where javascript will trigger a layout change (e.g. by passing a boolean variable to true), it's possible to measure the upper bound for the rendering. |
Contributor
There was a problem hiding this comment.
It is a bit vague, maybe an implemented example could help the user understand better here
cpaulve-1A
reviewed
Jan 20, 2025
| If you know exactly where javascript will trigger a layout change (e.g. by passing a boolean variable to true), it's possible to measure the upper bound for the rendering. | ||
|
|
||
| In addition, during a component development, you can't possibly know beforehand if the component will be relevant for a TTI or not, since it depends on the page itself. | ||
| For example, the display of a cart component may be relevant for TTI in a given page and not relevant at all in others. |
Contributor
There was a problem hiding this comment.
(product selection vs product recap?)
cpaulve-1A
reviewed
Jan 20, 2025
cpaulve-1A
reviewed
Jan 20, 2025
cpaulve-1A
reviewed
Jan 20, 2025
| As the browser can't understand when a route event happens in an SPA, the NavigationTimingAPI can't be directly used apart from the first page load at most. | ||
| Subsequent routing changes won't profit of the API connection timings. | ||
|
|
||
| In regard of the __server fetches__ (filter out from the resource timing API), the [PerformanceMetricPlugin](https://github.com/AmadeusITGroup/otter/blob/main/packages/@ama-sdk/core/src/plugins/perf-metric/perf-metric.fetch.ts) |
Contributor
There was a problem hiding this comment.
Suggested change
| In regard of the __server fetches__ (filter out from the resource timing API), the [PerformanceMetricPlugin](https://github.com/AmadeusITGroup/otter/blob/main/packages/@ama-sdk/core/src/plugins/perf-metric/perf-metric.fetch.ts) | |
| In regard of the __server fetches__ (filtered out from the resource timing API), the [PerformanceMetricPlugin](https://github.com/AmadeusITGroup/otter/blob/main/packages/@ama-sdk/core/src/plugins/perf-metric/perf-metric.fetch.ts) |
@sdo-1A : could you confirm this one please?
cpaulve-1A
reviewed
Jan 20, 2025
cpaulve-1A
reviewed
Jan 20, 2025
cpaulve-1A
reviewed
Jan 20, 2025
| ... | ||
|
|
||
| somethingHappened() { | ||
| this.eventTrackService.addUiEvent(new analyticsEvents.dummyEvent()) |
Contributor
There was a problem hiding this comment.
What does dummyEvent look like?
cpaulve-1A
reviewed
Jan 20, 2025
|
|
||
| ## TrackEventsModule | ||
|
|
||
| The `TrackEventsModule` contains directives to help you track standard event such as the `TrackClickDirective` or |
Contributor
There was a problem hiding this comment.
Suggested change
| The `TrackEventsModule` contains directives to help you track standard event such as the `TrackClickDirective` or | |
| The `TrackEventsModule` contains directives to help you track standard events such as the `TrackClickDirective` or |
cpaulve-1A
reviewed
Jan 20, 2025
|
|
||
| The `TrackEventsModule` contains directives to help you track standard event such as the `TrackClickDirective` or | ||
| `TrackFocusDirective`. | ||
| You can track more standard ui event with the `TrackEventsDirective` and even create your own component events |
Contributor
There was a problem hiding this comment.
Suggested change
| You can track more standard ui event with the `TrackEventsDirective` and even create your own component events | |
| You can track more standard ui events with the `TrackEventsDirective` and even create your own component events |
cpaulve-1A
reviewed
Jan 20, 2025
| <button | ||
| (click)="doSomethingElse()" | ||
| trackClick | ||
| [trackEventContext]="analyticsEvents.runtimeDummyEvent('You could send runtime data here')"></button> |
Contributor
There was a problem hiding this comment.
you should probably explain how these events look like before using them in the documentation
cpaulve-1A
reviewed
Jan 20, 2025
|
|
||
| ### TrackEvents directive | ||
|
|
||
| The directive will listen to the events on the element on which was applied and will expose the event captured using the track service. |
Contributor
There was a problem hiding this comment.
Suggested change
| The directive will listen to the events on the element on which was applied and will expose the event captured using the track service. | |
| The directive will listen to the events on the element on which it was applied to, and will expose the event captured using the track service. |
cpaulve-1A
reviewed
Jan 20, 2025
| | trackEvents | List of events which have to be tracked | ['mouseover', 'mouseenter'] | | ||
| | trackEventContext | Custom object to be exposed when the event is captured | {context: 'continueBtnClicked'} | | ||
|
|
||
| A specific directive for the click event was created, as it is the most used tracked event. |
Contributor
There was a problem hiding this comment.
Suggested change
| A specific directive for the click event was created, as it is the most used tracked event. | |
| As the click is the most tracked event, the `@o3r/analytics` provides a dedicated directive to support it. |
cpaulve-1A
reviewed
Jan 20, 2025
|
|
||
| ### Application level | ||
|
|
||
| At application level a subscription can be done to the observable emitted by the track events service. |
Contributor
There was a problem hiding this comment.
Suggested change
| At application level a subscription can be done to the observable emitted by the track events service. | |
| At application level, the track events service can subscribe to observables emitted by tracking events. |
cpaulve-1A
reviewed
Jan 20, 2025
packages/@o3r/analytics/src/fixtures/jasmine/event-track.service.fixture.jasmine.ts
Outdated
Show resolved
Hide resolved
kpanot
force-pushed
the
feature/analytics
branch
from
3dae4b0 to
4ede4dd
Compare
kpanot
force-pushed
the
feature/analytics
branch
from
4ede4dd to
e4af13b
Compare
|
This pull request has had no activity for 6 months and has been marked as stale. Please push new commits or comment to keep it open; otherwise it will be auto-closed in another 3 months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Provide a way to emit Analytics events to multiple providers:
Missing