Skip to content

Conversation

@fpaul-1A
Copy link
Contributor

@fpaul-1A fpaul-1A commented Dec 1, 2025

Proposed change

Missing:

  • ngx-markdown still has a peer dependency on zone.js
    -> non-blocking, issue is tracked here Zone.js as optional dependency jfcere/ngx-markdown#524
  • @nx/angular not updated to angular 21
    -> fixed in 22.3.0
  • design-factory, @agnos-ui/angular-bootstrap not updated to angular 21
    -> non-blocking
  • jest-preset-angular not updated to angular 21
    -> fixed in 16.0
  • @ngrx/router-store not updated to angular 21
    -> updated in 21.0.0
  • @angular-builders/jest not updated to angular 21
    -> fixed in 21.0.0-beta
  • ngx-monaco-editor-v2 not updated to angular 21
    -> non-blocking, pull-request opened here fix bugs and move to angular 21 miki995/ngx-monaco-editor-v2#44

Related issues

- No issue associated -

@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2025

View your CI Pipeline Execution ↗ for commit 4e11f06

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 1h 35m 7s View ↗
nx run-many --tui=false --target=build --projec... ✅ Succeeded 1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 2m 11s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 58s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 7s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 12m 43s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-13 12:23:37 UTC

@fpaul-1A fpaul-1A force-pushed the chore/angular-21 branch 4 times, most recently from 7046a16 to 229fe96 Compare December 17, 2025 19:45
@fpaul-1A fpaul-1A force-pushed the chore/angular-21 branch 4 times, most recently from a7399e8 to 5109f56 Compare January 8, 2026 14:53
@fpaul-1A fpaul-1A changed the title [draft] chore: upgrade angular 21 chore: upgrade angular 21 Jan 8, 2026
@fpaul-1A fpaul-1A marked this pull request as ready for review January 8, 2026 17:07
@fpaul-1A fpaul-1A requested a review from a team as a code owner January 8, 2026 17:07
@fpaul-1A fpaul-1A force-pushed the chore/angular-21 branch 6 times, most recently from ea1485a to 72e505d Compare January 9, 2026 14:53
@fpaul-1A fpaul-1A force-pushed the chore/angular-21 branch 2 times, most recently from 961b667 to 935b97b Compare January 12, 2026 10:14
: {
'@types/jasmine': o3rWorkspacePackageJson.generatorDependencies!['@types/jasmine']
},
: (options.useVitest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it documented somewhere that useJest takes priority over useVitest?
I see a potential issue in the current implementation. Even if you choose vitest in options.testingFramework, but you have a leftover dependency that contains jest (or the package name, or description etc) you will stil use jest. Maybe not to be tackled in this PR but, it might be worth to track it via an issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll have to do some more tests for sure to validate that everything works fine with jest/vitest

@fpaul-1A fpaul-1A merged commit b5a50d1 into release/14.0.0-next Jan 13, 2026
55 of 56 checks passed
@fpaul-1A fpaul-1A deleted the chore/angular-21 branch January 13, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project:@ama-mcp/angular project:@ama-mcp/core project:@ama-mcp/github project:@ama-mcp/otter project:@ama-mfe/messages project:@ama-mfe/ng-utils project:@ama-sdk/client-angular project:@ama-sdk/client-beacon project:@ama-sdk/client-fetch project:@ama-sdk/core project:@ama-sdk/create project:@ama-sdk/schematics project:@ama-sdk/swagger-builder project:@ama-styling/figma-extractor project:@ama-styling/figma-sdk project:@ama-styling/style-dictionary project:@ama-styling/stylelint-plugin project:@ama-terasu/cli project:@ama-terasu/core project:@ama-terasu/schematics project:audit-gh-action project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/amaterasu-api-spec project:@o3r/amaterasu-dodo project:@o3r/amaterasu-otter project:@o3r/amaterasu-sdk project:@o3r/analytics project:@o3r/apis-manager project:@o3r/application project:@o3r/artifactory-tools project:@o3r/azure-tools project:@o3r/build-helpers project:@o3r/chrome-devtools project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/create project:@o3r/design project:@o3r/dynamic-content project:@o3r/eslint-config project:@o3r/eslint-plugin project:@o3r/extractors project:@o3r/forms project:@o3r/github-cascading-app project:@o3r/localization project:@o3r/logger project:@o3r/mcp project:@o3r/mobile project:@o3r/new-version project:@o3r/palette-generator project:@o3r/pipeline project:@o3r/routing project:@o3r/rules-engine project:@o3r/schematics project:@o3r/showcase project:@o3r/store-sync project:@o3r/style-dictionary project:@o3r/stylelint-plugin project:@o3r/styling project:@o3r/telemetry project:@o3r/test-helpers project:@o3r/testing project:@o3r/third-party project:@o3r/workspace project:@o3r/workspace-helpers project:@o3r-training/showcase-sdk project:@o3r-training/training-sdk project:@o3r-training/training-tools project:otter-devtools project:release-gh-action project:yarn-errors-reporter-gh-action runAllTests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants