-
Notifications
You must be signed in to change notification settings - Fork 43
chore: upgrade angular 21 #3775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da44439 to
214495e
Compare
|
View your CI Pipeline Execution ↗ for commit 4e11f06
☁️ Nx Cloud last updated this comment at |
7046a16 to
229fe96
Compare
a7399e8 to
5109f56
Compare
ea1485a to
72e505d
Compare
961b667 to
935b97b
Compare
935b97b to
5e49114
Compare
5e49114 to
4e11f06
Compare
| : { | ||
| '@types/jasmine': o3rWorkspacePackageJson.generatorDependencies!['@types/jasmine'] | ||
| }, | ||
| : (options.useVitest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it documented somewhere that useJest takes priority over useVitest?
I see a potential issue in the current implementation. Even if you choose vitest in options.testingFramework, but you have a leftover dependency that contains jest (or the package name, or description etc) you will stil use jest. Maybe not to be tackled in this PR but, it might be worth to track it via an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll have to do some more tests for sure to validate that everything works fine with jest/vitest
Proposed change
Missing:
zone.js-> non-blocking, issue is tracked here Zone.js as optional dependency jfcere/ngx-markdown#524
@nx/angularnot updated to angular 21-> fixed in 22.3.0
design-factory,@agnos-ui/angular-bootstrapnot updated to angular 21-> non-blocking
jest-preset-angularnot updated to angular 21-> fixed in 16.0
@ngrx/router-storenot updated to angular 21-> updated in 21.0.0
@angular-builders/jestnot updated to angular 21-> fixed in 21.0.0-beta
ngx-monaco-editor-v2not updated to angular 21-> non-blocking, pull-request opened here fix bugs and move to angular 21 miki995/ngx-monaco-editor-v2#44
Related issues
- No issue associated -