-
Notifications
You must be signed in to change notification settings - Fork 42
chore: remove Babel transform from Jest #3813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cpaulve-1A
wants to merge
1
commit into
main
Choose a base branch
from
chore/remove-babel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /** | ||
| * Custom Jest resolver to map .mjs imports to .mts source files | ||
| * Required for ESM support with .mts files | ||
| * @see https://kulshekhar.github.io/ts-jest/docs/guides/esm-support#resolve-mjsmts-extensions | ||
| */ | ||
| module.exports = (path, options) => { | ||
| const mjsExtRegex = /\.mjs$/i; | ||
| const resolver = options.defaultResolver; | ||
|
|
||
| if (mjsExtRegex.test(path)) { | ||
| try { | ||
| return resolver(path.replace(mjsExtRegex, '.mts'), options); | ||
| } catch { | ||
| // Fall back to default resolver if .mts file doesn't exist | ||
| } | ||
| } | ||
|
|
||
| return resolver(path, options); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,18 @@ | ||
| const path = require('node:path'); | ||
| const { getTsJestBaseConfig, getOtterJestBaseConfig, getJestIntegrationTestConfig } = require('@o3r/test-helpers'); | ||
| const { createDefaultPreset } = require('ts-jest'); | ||
| const { createJsWithTsEsmPreset } = require('ts-jest'); | ||
|
|
||
| const rootDir = path.join(__dirname, '..'); | ||
|
|
||
| const tsJestConfig = { ...getTsJestBaseConfig(), useESM: true, diagnostics: { ignoreCodes: [151002] } }; | ||
|
|
||
| /** @type {import('ts-jest/dist/types').JestConfigWithTsJest} */ | ||
| module.exports = { | ||
| ...createDefaultPreset(getTsJestBaseConfig()), | ||
| ...createJsWithTsEsmPreset(tsJestConfig), | ||
| ...getOtterJestBaseConfig(rootDir), | ||
| ...getJestIntegrationTestConfig() | ||
| ...getJestIntegrationTestConfig(), | ||
| testEnvironment: 'node', | ||
| extensionsToTreatAsEsm: ['.ts', '.mts'], | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be inherited from otterBaseConfig |
||
| resolver: '<rootDir>/testing/jest-resolver.cjs', | ||
| injectGlobals: true, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,20 @@ | ||
| const path = require('node:path'); | ||
| const { getOtterJestBaseConfig, getJestUnitTestConfig } = require('@o3r/test-helpers'); | ||
| const { getOtterJestBaseConfig, getJestUnitTestConfig, getTsJestBaseConfig } = require('@o3r/test-helpers'); | ||
| const { createJsWithTsEsmPreset } = require('ts-jest'); | ||
|
|
||
| const rootDir = path.join(__dirname, '..'); | ||
|
|
||
| const tsJestConfig = { ...getTsJestBaseConfig(), useESM: true, diagnostics: { ignoreCodes: [151002] } }; | ||
|
|
||
| /** @type {import('ts-jest/dist/types').JestConfigWithTsJest} */ | ||
| module.exports = { | ||
| ...createJsWithTsEsmPreset(tsJestConfig), | ||
| ...getOtterJestBaseConfig(rootDir), | ||
| ...getJestUnitTestConfig(), | ||
| transform: { | ||
| '^.+\\.([mc]?[tj]sx?)$': ['babel-jest', { configFile: path.join(__dirname, 'babel.config.mjs') }] | ||
| }, | ||
| extensionsToTreatAsEsm: ['.mts'], | ||
| setupFilesAfterEnv: ['<rootDir>/testing/setup-jest.ts'] | ||
| ...getJestUnitTestConfig({ | ||
| setupFilesAfterEnv: ['<rootDir>/testing/setup-jest.mjs'], | ||
| testEnvironment: 'node', | ||
| extensionsToTreatAsEsm: ['.ts', '.mts'], | ||
| resolver: '<rootDir>/testing/jest-resolver.cjs', | ||
| injectGlobals: true | ||
| }), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| // Jest setup file for ama-openapi-core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /** | ||
| * Jest setup file for ESM mode | ||
| * Makes Jest globals available without explicit imports in test files | ||
| */ | ||
| import * as jestGlobals from '@jest/globals'; | ||
|
|
||
| // Make all Jest globals available | ||
| globalThis.jest = jestGlobals.jest; | ||
| globalThis.expect = jestGlobals.expect; | ||
| globalThis.describe = jestGlobals.describe; | ||
| globalThis.it = jestGlobals.it; | ||
| globalThis.test = jestGlobals.test; | ||
| globalThis.beforeEach = jestGlobals.beforeEach; | ||
| globalThis.afterEach = jestGlobals.afterEach; | ||
| globalThis.beforeAll = jestGlobals.beforeAll; | ||
| globalThis.afterAll = jestGlobals.afterAll; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| // Jest setup file for ama-openapi-core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 0 additions & 6 deletions
6
packages/@ama-openapi/redocly-plugin/testing/babel.config.mjs
This file was deleted.
Oops, something went wrong.
19 changes: 19 additions & 0 deletions
19
packages/@ama-openapi/redocly-plugin/testing/jest-resolver.cjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /** | ||
| * Custom Jest resolver to map .mjs imports to .mts source files | ||
| * Required for ESM support with .mts files | ||
| * @see https://kulshekhar.github.io/ts-jest/docs/guides/esm-support#resolve-mjsmts-extensions | ||
| */ | ||
| module.exports = (path, options) => { | ||
| const mjsExtRegex = /\.mjs$/i; | ||
| const resolver = options.defaultResolver; | ||
|
|
||
| if (mjsExtRegex.test(path)) { | ||
| try { | ||
| return resolver(path.replace(mjsExtRegex, '.mts'), options); | ||
| } catch { | ||
| // Fall back to default resolver if .mts file doesn't exist | ||
| } | ||
| } | ||
|
|
||
| return resolver(path, options); | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if required even with the pathMapper