Feature/max one click transfer #1799
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/one-click-transfer-reserve-for-fee
Oxbobby
changed the title
jordan-enev
reviewed
Sep 25, 2025
jordan-enev
reviewed
Sep 25, 2025
| if (userRequest && userRequest.action.kind === 'calls') { | ||
| this.signAccountOpController.accountOp.calls = userRequest.action.calls | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Why do we need the else logic? op.calls already holds the transaction, doesn't it?
Member
Author
There was a problem hiding this comment.
We're updating the calls depending on the chosen fee token. If the first case is "send max USDT and pay in USDT", we will perform the "if" calculation. But if the user then changes to another fee option instead, we enter the "else" and allow the user to send the full max USDT he has. Otherwise, he would have sent the subtracted value
…/one-click-transfer-reserve-for-fee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: https://github.com/AmbireTech/ambire-app/pull/5573