Refactoring / Мake signAccountOpController part of the request #2054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetromirDev
requested changes
Dec 19, 2025
Comment on lines
2416
to
2420
| if (this.#signAccountOpController?.broadcastStatus === 'SUCCESS') { | ||
| setTimeout(() => { | ||
| this.resetForm() | ||
| }, 0) | ||
| } |
Member
There was a problem hiding this comment.
you can move the emit update to an else statement to prevent double emits
Collaborator
Author
There was a problem hiding this comment.
An update is required, followed by another one on the next tick to receive the last update from the signAccountOpController before the resetForm func destroys it. It is just a workaround because the onUpdate with forceEmitUpdates does not work properly in controllers and it is a temp fix until we find a solution of the problem with the event emitter
Comment on lines
911
to
915
|
|
||
| if (this.signAccountOpController?.broadcastStatus === 'SUCCESS') { | ||
| setTimeout(() => { | ||
| this.resetForm() | ||
| }, 0) |
Member
There was a problem hiding this comment.
you can move the emit update to an else statement to prevent double emits
PetromirDev
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.