Enhancement/ Safety level ranking flag to tokens #900
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivshti
requested changes
Jul 27, 2024
Member
Ivshti
left a comment
Ivshti
left a comment
There was a problem hiding this comment.
I don't understand the logic and I think the code can be rewritten to be better
JIOjosBG
requested changes
Jul 31, 2024
PetromirDev
changed the title
JIOjosBG
approved these changes
Aug 12, 2024
Member
JIOjosBG
left a comment
JIOjosBG
left a comment
There was a problem hiding this comment.
lgtm, really liked how you optimized for long arrays of tokens
| // thus we can't trust it | ||
| if (!canTokenBeChecked) return undefined | ||
|
|
||
| Object.values(humanizerInfo.knownAddresses as unknown as HumanizerMeta).some((value) => { |
Member
There was a problem hiding this comment.
add comment about .some() doing a break on return true and continue on return false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new token flag is introduced. It is
safetyLeveland the values it accepts are:networkIdor even betterchainId