Fix precision and F1 score calculations #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the guard
if n > 0 else 0.0might be wrong here because precision and F1 metrics are well-defined for tests which don't have any "negative" samples.Running the current tutorial code from https://github.com/AmenRa/GuardBench/blob/main/docs/llama_guard.md results with the following table:
Notice
0.0forAdvBench Behaviors/Strings. This is coming due to the fact that these tests have only positive samples.After the fix in this PR, the table looks as expected and showcased in your tutorial at https://github.com/AmenRa/GuardBench/blob/main/docs/llama_guard.md