Sandbox: Improved Global Error Handler, Duplicate Handling, Enrollment Concurrency Improvement#328
Merged
CritiqalPete merged 10 commits intosandboxfrom Mar 24, 2025
Merged
Conversation
1) `attributes` are saved into `vars.originalAttributes` and used while sending error notifications through Slack 2) Slack error messages include the same message as what the client receives 3) Added "Message to user" to the Slack message to indicate `message` field received by the client 4) Implemented Correct Handling of the Duplicate Errors
1. Remove the part that manually queries the database to find duplicates – This logic should come from Salesforce. 2. Remove the “missing fields” custom error – This should be handled by APIKIT.
…st.py` for testing
CritiqalPete
approved these changes
Mar 24, 2025
Member
CritiqalPete
left a comment
CritiqalPete
left a comment
There was a problem hiding this comment.
key stability improvements thanks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the global error handler mainly to address the issues with
CREATECONTACT:CONFLICTerrors over the past few weeks. In addition, I addressed the issue mentioned in #284, but we might need to change the message delivered to the user (coach).All changes
attributesfield is saved intovars.originalAttributesand used while sending error notifications through Slack. This preventsEndpoint: N/A N/Amessages.messagefield received by the client.Examples
Create Duplicate Error
Mailformed ID
Search with 1 character
UNABLE_TO_LOCK_ROWerror when creating Enrollments