Use consistent ordering in T2Compute.ingest and StateT2Dependency.link_override#333
Merged
jvansanten merged 5 commits intomasterfrom Feb 1, 2026
Merged
Use consistent ordering in T2Compute.ingest and StateT2Dependency.link_override#333jvansanten merged 5 commits intomasterfrom
jvansanten merged 5 commits intomasterfrom
Conversation
jvansanten
force-pushed
the
link_override_ordering
branch
from
e6d21b0 to
45a6615
Compare
jvansanten
force-pushed
the
link_override_ordering
branch
from
45a6615 to
5e96689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sort applied by
T2Compute.ingestto select targets for point T2s different from the one applied inStateT2Dependency.link_overrideif all the following conditions are met:DPSelection.sortrefers to a field whose values in the datapoint set are not uniqueChainedIngestionHandler.ingest()T1Compiler.sort==trueThis causes missing point t2 dependencies of state t2s. This PR adds an integration test that demonstrates the problem, and addresses it by presenting datapoints to filter/sort/select in
ingest_point_t2s()in the same order they are stored in the T1 document.