Add ability to configure Sigmax return state#1466
Open
bartjkdp wants to merge 2 commits intoAmsterdam:mainfrom
Open
Add ability to configure Sigmax return state#1466bartjkdp wants to merge 2 commits intoAmsterdam:mainfrom
bartjkdp wants to merge 2 commits intoAmsterdam:mainfrom
Conversation
75edebc to
1c886a4
Compare
ffd72a0 to
8ab4d08
Compare
Contributor
Author
|
We are currently testing this change in Leiden. |
8ab4d08 to
73808aa
Compare
73808aa to
2665e19
Compare
2665e19 to
017e2a7
Compare
fa7370b to
6160312
Compare
5feb8ef to
2adf7a8
Compare
2adf7a8 to
4323527
Compare
joeyamst
requested changes
Jan 12, 2026
| ], | ||
| VERZONDEN: [ | ||
| AFGEHANDELD_EXTERN, | ||
| AFGEHANDELD, |
Contributor
There was a problem hiding this comment.
I would prefer if the state machine workflow is not adjusted for this use case. My prefered solution would be if the flow VERZONDEN -> AFGEHANDELD_EXTERN -> AFGEHANDELD is still used. I understand this is an extra database call for this specific use case, but keeping the correct flow is a fair trade-off for me.
Could you remove the change to the workflow, and instead do a double state change instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it possible to configure the Sigmax return state. Currently the status in Signalen always returns to "done external" (Extern: afgehandeld), but some municipalities would like to be able to set the status to "o" (Afgehandeld).
Checklist
mainand is up to date withmainmainHow has this been tested?