Merged
Conversation
This is in the setup.py but it is useful to be able to run it on its own
Remove min_version and max_version. These behaviour of these properties was confusing. Add (min/max/max_known) semantic_version and block_version properties. These are clearer what they do. max_known indicates a real version to use as an upper bound. max is generally not a real version and exists purely to catch future versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
min_versionandmax_version. These behaviour of these properties was confusing.Add (
min/max/max_known)semantic_versionandblock_versionproperties.These are clearer what they do.
max_known indicates a real version to use as an upper bound. max is generally not a real version and exists purely to catch future versions.