Use a 'default' instead of a 'decorative' font family #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Unix systems, the wxWidgets / wxPython font family `wx.DECORATIVE` defaults to Impact [^1]. For a more suitable UI font, this is changed to `wx.DEFAULT`. On modern macOS and Windows systems, this is expected to have minimal impact (no pun intended), as `wx.DECORATIVE` already seems to be equivalent to `wx.DEFAULT` on both platforms [^2][^3]. Even with its original intent, the 'decorative' font family is not a good match for the UI, as it corresponds to the `fantasy` font family in CSS, that mostly includes gimmicky fonts like Papyrus or Jokerman [^4]. [^1]: https://github.com/wxWidgets/wxWidgets/blob/18da5b8269706472f6c0fa09dcbae605a477da19/src/unix/fontutil.cpp#L274-L277 [^2]: https://github.com/wxWidgets/wxWidgets/blob/18da5b8269706472f6c0fa09dcbae605a477da19/src/osx/carbon/font.cpp#L218-L220 [^3]: wxWidgets/wxWidgets#24178 [^4]: https://web.archive.org/web/20130126125901/http://www.codestyle.org/css/font-family/sampler-Fantasy.shtml
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Unix systems, the wxWidgets / wxPython font family
wx.DECORATIVEdefaults to Impact 1. For a more suitable UI font, this is changed towx.DEFAULT.On modern macOS and Windows systems, this is expected to have minimal impact (no pun intended), as
wx.DECORATIVEalready seems to be equivalent towx.DEFAULTon both platforms 23.Even with its original intent, the 'decorative' font family is not a good match for the UI, as it corresponds to the
fantasyfont family in CSS, that mostly includes gimmicky fonts like Papyrus or Jokerman 4.Resolves #1172
Footnotes
https://github.com/wxWidgets/wxWidgets/blob/18da5b8269706472f6c0fa09dcbae605a477da19/src/unix/fontutil.cpp#L274-L277 ↩
https://github.com/wxWidgets/wxWidgets/blob/18da5b8269706472f6c0fa09dcbae605a477da19/src/osx/carbon/font.cpp#L218-L220 ↩
https://github.com/wxWidgets/wxWidgets/issues/24178 ↩
https://web.archive.org/web/20130126125901/http://www.codestyle.org/css/font-family/sampler-Fantasy.shtml ↩