Limit meshing to 1 thread #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my 16 core CPU Amulet was maxing out the whole processor but was not getting much of a speed boost. I think most of the CPU time is spent spawning and destroying threads because the work being done is so small. After profiling it seems that adding more threads makes it a little faster but not much. Using all cores makes it run slower than just one. I think most of the benefit is from running the meshing code independently of the GIL. I have decided to limit meshing to 1 thread. Tests (times in seconds + frames out of 60) range with gil = 41+19 prange(cpu) = 33+24 prange(4) = 31+05 prange(2) = 31+14 prange(1) = 31+36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my 16 core CPU Amulet was maxing out the whole processor but was not getting much of a speed boost. I think most of the CPU time is spent spawning and destroying threads because the work being done is so small. After profiling it seems that adding more threads makes it a little faster but not much. Using all cores makes it run slower than just one. I think most of the benefit is from running the meshing code independently of the GIL. I have decided to limit meshing to 1 thread.
Tests (times in seconds + frames out of 60)
range with gil = 41+19
prange(cpu) = 33+24
prange(4) = 31+05
prange(2) = 31+14
prange(1) = 31+36