matplotlib 3.11.1 - #40
maciejtraczyk wants to merge 1 commit into
Conversation
29e36ea to
f1199ed
Compare
Failed to submit graph for f1199edMessage: INFO:root:Creating graph from feedstock at: matplotlib-feedstock |
f1199ed to
95c0e87
Compare
| run: | ||
| - python | ||
| - pyqt >=5 # [(linux64 or win) and python_impl == "cpython"] | ||
| - pyqt {{pyqt}} # [(linux64 or win) and python_impl == "cpython"] |
There was a problem hiding this comment.
| - pyqt {{pyqt}} # [(linux64 or win) and python_impl == "cpython"] | |
| - pyqt >=5 # [(linux64 or win) and python_impl == "cpython"] |
Prefer >=5 notation in the run section over {{pyqt}} (it's designed for the host section).
Do we need pyqt {{pyqt}} in the host to pin it 6.11? See https://github.com/AnacondaRecipes/aggregate/blob/master/conda_build_config.yaml#L891C6-L891C10
There was a problem hiding this comment.
this change was change was suggested by linter check but you're right it suppose to apply only to the host section I had to missed that.
"matplotlib-feedstock/recipe/meta.yaml:/outputs/1/requirements/host/1: host_section_needs_exact_pinnings: pyqt in host should be pinned to its conda_build_config.yaml value: pyqt {{ pyqt }}."
when it comes to bumping pyqt into 6.11 I think we can stay with >= 5 as there Is no sign of it as a requirement so to avoid further solver conflicts In my opinion we can stay with >=5, unless I missing something @skupr-anaconda?
There was a problem hiding this comment.
The linter flags pinning in host so that a specific version is used (i.e. the one set in the cbc).
The runtime constraint itself is set by the run_exports of the package (https://github.com/AnacondaRecipes/pyqt-feedstock/blob/master/recipe/meta.yaml#L65).
So
host:
- pyqt {{ pyqt }}
run:
- pyqt >=5
Will render as:
host:
- pyqt 6.11
run:
- pyqt >=5
- pyqt >=6.11.0,<6.12.0
We shouldn't pin in run to pyqt {{ pyqt }}
bump matplotlib 3.11.0 → 3.11.1