forked from Azure/azure-functions-durable-python
-
Notifications
You must be signed in to change notification settings - Fork 1
Scaffold initial orchestration tests #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
philliphoff
merged 12 commits into
durable-openai-agent
from
philliphoff-add-initial-tests
Sep 5, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2e91846
Scaffold some basic tests.
philliphoff b811548
Move OpenAI tests.
philliphoff c962be0
Move OpenAI tests.
philliphoff 18c9378
Add tests for tool use.
philliphoff 20994db
Merge branch 'durable-openai-agent' into philliphoff-add-initial-tests
philliphoff c0029dc
Fixup merge.
philliphoff dea3a53
Resolve annotations error.
philliphoff 3e9d95f
A better way to resolve linter.
philliphoff 07e2ad7
Fixup linter.
philliphoff e660931
Try eliminate test failure.
philliphoff edf283e
Try again.
philliphoff d676264
Try, try, again.
philliphoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to double-check: my understanding is that adding openai and openai-agents here will not mean that every app installing azure-functions-durable will automatically install these packages as well, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's my understanding as well--that these are requirements just for the repo. As far as I know, the dependencies of the package are specified in
setup.py
. We do have to be careful, I believe, not to let imports of OpenAI dependencies leak into files that shouldn't necessarily require them. That is, to use "local" imports where necessary instead of imports at the top of the file.