Save the last search term and added a button to clear text

[agrogers]

• The previous search text is now saved
• Button added to clear that text if when you don't want it

[tuomas2]

Contains new strings, so 4.1

[tuomas2]

Bug:

1. Open Find
2. Write "Jesus"
3. Enable "Remember search text"
4. Click "Find"
5. Click back btn
   -> "Remeber search text" is disabled
   (should be enabled)

[tuomas2]

I think this would be better: #186 (comment)
What do you think about implementing that instead?

[agrogers]

Yeah, I have wanted that at times also. I think there is a place for both remembering, clearing with the X and selecting from a history list. So saving the last term and having an option to disable it is still helpful to me. What control would you use for the drop down list?

…

On Fri, 14 Jan 2022, 12:58 am Tuomas Airaksinen, ***@***.***> wrote: I think this would be better: #186 (comment) <#186 (comment)> What do you think about implementing that instead? — Reply to this email directly, view it on GitHub <#2004 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKGTJQMTJLR6KRPQXNFRDDUV3SCHANCNFSM5KY3RAAQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tuomas2]

What control would you use for the drop down list?

I have used AutoCompleteTextView in document selection (see document_selection.xml). I think it would work here.

[Copilot]

Pull Request Overview

This PR enhances the search functionality by saving the last search term and introducing a clear text button.

• Stores the user's preference to remember the last search string.
• Automatically pre-loads the saved search text if available.
• Adds a button to clear the search text on demand.

Files not reviewed (2)

• app/src/main/res/layout/search.xml: Language not supported
• app/src/main/res/values/strings.xml: Language not supported

[Copilot]

When clearing the search text in the UI, the persisted search text is not updated. Consider also clearing or updating the saved 'search_text' preference so that the cleared state is reflected across sessions.

Suggested change

	binding.textClear.setOnClickListener({binding.searchText.setText("")})
	binding.textClear.setOnClickListener({
	binding.searchText.setText("")
	val sharedPreferences = getSharedPreferences("search_preferences", MODE_PRIVATE)
	sharedPreferences.edit().putString("search_text", "").apply()
	})