Improve code formatting for verse selection logic#3585
Improve code formatting for verse selection logic#3585Copilot wants to merge 4 commits intoGoto-verse-0-when-verse-1-selectedfrom
Conversation
…icit verse 1 selection Co-authored-by: agrogers <13920678+agrogers@users.noreply.github.com>
|
@copilot When a user selects verse 1 from the verse selector, we want to display verse 0. So your change for this needs to be undone. |
agrogers
left a comment
There was a problem hiding this comment.
Reverse this change. We want to go to verse 0 if they select verse 1 in the chooser.
…lection Co-authored-by: agrogers <13920678+agrogers@users.noreply.github.com>
Reverted the change in commit 1c51a92. The verse 1 → verse 0 conversion is now restored in |
Co-authored-by: agrogers <13920678+agrogers@users.noreply.github.com>
The current code already converts verse 1 to verse 0 as intended. Line 123 has |
|
This is towards your own PR so you can merge it yourself? |
|
Copilot made this. I think I merged it but to be honest I am never sure I
get git right. I will look at it again
…___________________________
*www.TenOutOfTen.org* <https://www.TenOutOfTen.org>
***@***.***
(+61) 0477 174 193 (Australia)
(+95) 09 250018669 (Myanmar)
On Tue, 6 Jan 2026, 00:15 Tuomas Airaksinen, ***@***.***> wrote:
*tuomas2* left a comment (AndBible/and-bible#3585)
<#3585 (comment)>
This is towards your own PR so you can merge it yourself?
—
Reply to this email directly, view it on GitHub
<#3585 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKGTJUSY6A3RB4NE3WFQTT4FKPNHAVCNFSM6AAAAACQFUIUL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJRGQ2DSOBTGU>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
The original implementation already correctly converts verse 1 selections to verse 0 (chapter heading). This PR improves the code formatting to follow Kotlin conventions.
Changes
GridChoosePassageVerse.kt: Added proper spacing around the!=operator for better readabilityBehavior
Both navigation methods consistently display verse 0 (chapter heading):
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.