Skip to content

add homework#6 Generics #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eyvoil wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add homework#6 Generics #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/main/kotlin/ru/kotlin/homework/network/NetworkLogger.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ sealed class ApiException(message: String) : Throwable(message) {
data object UnknownException: ApiException("Unknown exception")
}

class ErrorLogger<E : Throwable> {
class ErrorLogger<in E : Throwable> {

val errors = mutableListOf<Pair<LocalDateTime, E>>()
private val errors = mutableListOf<Pair<LocalDateTime, Throwable>>()

fun log(response: NetworkResponse<*, E>) {
if (response is Failure) {
Expand All @@ -30,6 +30,10 @@ class ErrorLogger<E : Throwable> {
println("Error at $date: ${error.message}")
}
}

fun dump(): MutableList<Pair<LocalDateTime, Throwable>> {
return errors
}
}

fun processThrowables(logger: ErrorLogger<Throwable>) {
Expand Down Expand Up @@ -60,5 +64,8 @@ fun main() {

println("Processing Api:")
processApiErrors(logger)

println(logger.dump())

}

6 changes: 3 additions & 3 deletions src/main/kotlin/ru/kotlin/homework/network/NetworkResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,19 @@ import java.time.LocalDateTime
/**
* Network result
*/
sealed class NetworkResponse<T, R> {
sealed class NetworkResponse<out T, out R> {
val responseDateTime: LocalDateTime = LocalDateTime.now()
}

/**
* Network success
*/
data class Success<T, R>(val resp: T): NetworkResponse<T, R>()
data class Success<out T>(val resp: T): NetworkResponse<T, Nothing>()

/**
* Network error
*/
data class Failure<T, R>(val error: R): NetworkResponse<T, R>()
data class Failure<out R>(val error: R): NetworkResponse<Nothing, R>()

val s1 = Success("Message")
val r11: NetworkResponse<String, Error> = s1
Expand Down