Skip to content

fix: add "boolean" type to storage#507

Open
GlitchApotamus wants to merge 1 commit intoAndroz2091:masterfrom
GlitchApotamus:patch-1
Open

fix: add "boolean" type to storage#507
GlitchApotamus wants to merge 1 commit intoAndroz2091:masterfrom
GlitchApotamus:patch-1

Conversation

@GlitchApotamus
Copy link

This allows typescript users to write storage: false in the options.

Changes

Status

  • [ x ] These changes have been tested and formatted properly.
  • This PR includes only documentation changes (JSDoc, README or typings), no code change.
  • This PR introduces some breaking changes.

This allows typescript users to write `storage: false` in the options.
@Nico105
Copy link
Collaborator

Nico105 commented Jun 28, 2023

If I'm not mistaken it's not necessary to set it to false anymore.
The code example with that included should be removed.
So you can just not use it / leave it undefined, no?

@GlitchApotamus
Copy link
Author

When I don't use it, it defaults to "./giveaways.json" and undefined will also fault out in typescript because it's not a string

@Nico105
Copy link
Collaborator

Nico105 commented Jul 1, 2023

But so are you using a custom db?
Because if you are extending the getAllGiveaways function then the "default" shouldn't matter to you.

So I don't really understand what you are trying to achieve/what your logic is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants