fix: add "boolean" type to storage#507
Open
GlitchApotamus wants to merge 1 commit intoAndroz2091:masterfrom
Open
fix: add "boolean" type to storage#507GlitchApotamus wants to merge 1 commit intoAndroz2091:masterfrom
GlitchApotamus wants to merge 1 commit intoAndroz2091:masterfrom
Conversation
This allows typescript users to write `storage: false` in the options.
Collaborator
|
If I'm not mistaken it's not necessary to set it to false anymore. |
Author
|
When I don't use it, it defaults to "./giveaways.json" and undefined will also fault out in typescript because it's not a string |
Collaborator
|
But so are you using a custom db? So I don't really understand what you are trying to achieve/what your logic is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows typescript users to write storage: false in the options.
Changes
Status