Version 1.1 #121
Draft
Version 1.1 #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cannot enter native fullscreen without interaction
Re-added the for header/footer to override bootstraps d-flex
This PR implements a full-screen button on the video stream, that switches ankerctl to a full-screen view, with the print job status on the right hand side. @billyjbryant implemented an "emulated fullscreen mode" that can be activated by `?fullscreen=1` as an url parameter.
Set config upload to accept .json files
Split upload action to a new function so both gcode upload 'cli' & 'web' could use the same function Updated way modal is displayed to allow reuse
Fixing no return not causing page to reload
A: Print as popup modal with separate button B: Print as separate page with menu button
Fixing auto-formatting for the bajillionth time
Adding docstring to upload_file_to_printer
### Description This PR adds a new upload button to the home page that allows for uploading gcode files directly from the Web UI ### Preview  ### Console logs: ```sh [*] FileTransferService: Requesting start [*] FileTransferService: Worker started [*] Going to upload 12729275 bytes as 'wall-honeycomb-224x190size_mk3s__0.20mm_PLA_M5.gcode' [*] Requesting file transfer.. [*] TOPIC [/phone/maker/AK7ZRG0C35700749/notice] [*] Sending file metadata.. [*] Sending file contents.. [*] TOPIC [/phone/maker/AK7ZRG0C35700749/notice] [*] TOPIC [/phone/maker/AK7ZRG0C35700749/notice] [*] TOPIC [/phone/maker/AK7ZRG0C35700749/notice] [*] TOPIC [/phone/maker/AK7ZRG0C35700749/notice] [*] File upload complete. Requesting print start of job. [*] Successfully sent print job [*] FileTransferService: Requesting stop [*] FileTransferService: Worker stopped ``` ### Testing PPPP print-file To ensure that `pppp print-file` continues to work I tested it as well: ```sh billy …/ankermake-m5-protocol web-gcode-upload $ ♥ 08:34 ./ankerctl.py pppp print-file -n /mnt/c/Users/billy/OneDrive/Documents/3dPrinterSD/0_SLICED/FDM/wall-honeycomb-224x190size\(mk3s\)_0.20mm_PLA_M5.gcode [*] Trying connect to printer Vulcan (USPRAKM-008574-TPUPS) over pppp using ip 192.168.4.145 [*] Established pppp connection [*] Going to upload 12729275 bytes as 'wall-honeycomb-224x190size_mk3s__0.20mm_PLA_M5.gcode' [*] Requesting file transfer.. [*] Sending file metadata.. [*] Sending file contents.. 100%|████████████████████████████████████████████████████████████████████████████████████████████| 12.1M/12.1M [00:18<00:00, 694kb/s] [*] File upload complete ``` Fixes: #112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress PR for version 1.1