Skip to content

Commit 0129324

Browse files
committed
Update tests for cascades
1 parent b264e48 commit 0129324

File tree

5 files changed

+19
-19
lines changed

5 files changed

+19
-19
lines changed

tests/test_create.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ def test_self_referential_foreign_key(fresh_db):
303303
assert (
304304
"CREATE TABLE [test_table] (\n"
305305
" [id] INTEGER PRIMARY KEY,\n"
306-
" [ref] INTEGER REFERENCES [test_table]([id])\n"
306+
" [ref] INTEGER REFERENCES [test_table]([id]) ON UPDATE CASCADE ON DELETE CASCADE\n"
307307
")"
308308
) == table.schema
309309

@@ -491,7 +491,7 @@ def test_add_column_foreign_key(fresh_db):
491491
assert fresh_db["dogs"].schema == (
492492
'CREATE TABLE "dogs" (\n'
493493
" [name] TEXT,\n"
494-
" [breed_id] INTEGER REFERENCES [breeds]([rowid])\n"
494+
" [breed_id] INTEGER REFERENCES [breeds]([rowid]) ON UPDATE CASCADE ON DELETE CASCADE\n"
495495
")"
496496
)
497497
# And again with an explicit primary key column
@@ -500,8 +500,8 @@ def test_add_column_foreign_key(fresh_db):
500500
assert fresh_db["dogs"].schema == (
501501
'CREATE TABLE "dogs" (\n'
502502
" [name] TEXT,\n"
503-
" [breed_id] INTEGER REFERENCES [breeds]([rowid]),\n"
504-
" [subbreed_id] TEXT REFERENCES [subbreeds]([primkey])\n"
503+
" [breed_id] INTEGER REFERENCES [breeds]([rowid]) ON UPDATE CASCADE ON DELETE CASCADE,\n"
504+
" [subbreed_id] TEXT REFERENCES [subbreeds]([primkey]) ON UPDATE CASCADE ON DELETE CASCADE\n"
505505
")"
506506
)
507507

@@ -514,7 +514,7 @@ def test_add_foreign_key_guess_table(fresh_db):
514514
assert fresh_db["dogs"].schema == (
515515
'CREATE TABLE "dogs" (\n'
516516
" [name] TEXT,\n"
517-
" [breed_id] INTEGER REFERENCES [breeds]([id])\n"
517+
" [breed_id] INTEGER REFERENCES [breeds]([id]) ON UPDATE CASCADE ON DELETE CASCADE\n"
518518
")"
519519
)
520520

tests/test_extract.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def test_extract_single_column(fresh_db, table, fk_column):
2626
'CREATE TABLE "tree" (\n'
2727
" [id] INTEGER PRIMARY KEY,\n"
2828
" [name] TEXT,\n"
29-
" [{}] INTEGER REFERENCES [{}]([id]),\n".format(expected_fk, expected_table)
29+
" [{}] INTEGER REFERENCES [{}]([id]) ON UPDATE CASCADE ON DELETE CASCADE,\n".format(expected_fk, expected_table)
3030
+ " [end] INTEGER\n"
3131
+ ")"
3232
)
@@ -73,7 +73,7 @@ def test_extract_multiple_columns_with_rename(fresh_db):
7373
'CREATE TABLE "tree" (\n'
7474
" [id] INTEGER PRIMARY KEY,\n"
7575
" [name] TEXT,\n"
76-
" [common_name_latin_name_id] INTEGER REFERENCES [common_name_latin_name]([id])\n"
76+
" [common_name_latin_name_id] INTEGER REFERENCES [common_name_latin_name]([id]) ON UPDATE CASCADE ON DELETE CASCADE\n"
7777
")"
7878
)
7979
assert fresh_db["common_name_latin_name"].schema == (
@@ -123,7 +123,7 @@ def test_extract_rowid_table(fresh_db):
123123
assert fresh_db["tree"].schema == (
124124
'CREATE TABLE "tree" (\n'
125125
" [name] TEXT,\n"
126-
" [common_name_latin_name_id] INTEGER REFERENCES [common_name_latin_name]([id])\n"
126+
" [common_name_latin_name_id] INTEGER REFERENCES [common_name_latin_name]([id]) ON UPDATE CASCADE ON DELETE CASCADE\n"
127127
")"
128128
)
129129
assert (
@@ -153,14 +153,14 @@ def test_reuse_lookup_table(fresh_db):
153153
assert fresh_db["sightings"].schema == (
154154
'CREATE TABLE "sightings" (\n'
155155
" [id] INTEGER PRIMARY KEY,\n"
156-
" [species_id] INTEGER REFERENCES [species]([id])\n"
156+
" [species_id] INTEGER REFERENCES [species]([id]) ON UPDATE CASCADE ON DELETE CASCADE\n"
157157
")"
158158
)
159159
assert fresh_db["individuals"].schema == (
160160
'CREATE TABLE "individuals" (\n'
161161
" [id] INTEGER PRIMARY KEY,\n"
162162
" [name] TEXT,\n"
163-
" [species_id] INTEGER REFERENCES [species]([id])\n"
163+
" [species_id] INTEGER REFERENCES [species]([id]) ON UPDATE CASCADE ON DELETE CASCADE\n"
164164
")"
165165
)
166166
assert list(fresh_db["species"].rows) == [

tests/test_extracts.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def test_extracts(fresh_db, kwargs, expected_table, use_table_factory):
3636
== fresh_db[expected_table].schema
3737
)
3838
assert (
39-
"CREATE TABLE [Trees] (\n [id] INTEGER,\n [species_id] INTEGER REFERENCES [{}]([id])\n)".format(
39+
"CREATE TABLE [Trees] (\n [id] INTEGER,\n [species_id] INTEGER REFERENCES [{}]([id]) ON UPDATE CASCADE ON DELETE CASCADE\n)".format(
4040
expected_table
4141
)
4242
== fresh_db["Trees"].schema

tests/test_lookup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@ def test_lookup_with_extra_insert_parameters(fresh_db):
121121
" [type] TEXT,\n"
122122
" [first_seen] TEXT,\n"
123123
" [make_not_null] INTEGER NOT NULL,\n"
124-
" [fk_to_other] INTEGER REFERENCES [other_table]([id]),\n"
124+
" [fk_to_other] INTEGER REFERENCES [other_table]([id]) ON UPDATE CASCADE ON DELETE CASCADE,\n"
125125
" [default_is_dog] TEXT DEFAULT 'dog',\n"
126-
" [extract_this] INTEGER REFERENCES [extract_this]([id]),\n"
126+
" [extract_this] INTEGER REFERENCES [extract_this]([id]) ON UPDATE CASCADE ON DELETE CASCADE,\n"
127127
" [convert_to_upper] TEXT,\n"
128128
" [make_this_integer] INTEGER\n"
129129
")"

tests/test_transform.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ def test_transform_verify_foreign_keys(fresh_db):
398398
try:
399399
fresh_db["authors"].transform(rename={"id": "id2"})
400400
fresh_db.commit()
401-
except apsw.ConstraintError:
401+
except apsw.SQLError:
402402
fresh_db.rollback()
403403

404404
# This should have rolled us back
@@ -435,9 +435,9 @@ def test_transform_add_foreign_keys_from_scratch(fresh_db):
435435
'CREATE TABLE "places" (\n'
436436
" [id] INTEGER,\n"
437437
" [name] TEXT,\n"
438-
" [country] INTEGER REFERENCES [country]([id]),\n"
439-
" [continent] INTEGER REFERENCES [continent]([id]),\n"
440-
" [city] INTEGER REFERENCES [city]([id])\n"
438+
" [country] INTEGER REFERENCES [country]([id]) ON UPDATE CASCADE ON DELETE CASCADE,\n"
439+
" [continent] INTEGER REFERENCES [continent]([id]) ON UPDATE CASCADE ON DELETE CASCADE,\n"
440+
" [city] INTEGER REFERENCES [city]([id]) ON UPDATE CASCADE ON DELETE CASCADE\n"
441441
")"
442442
)
443443

@@ -506,8 +506,8 @@ def test_transform_replace_foreign_keys(fresh_db, foreign_keys):
506506
'CREATE TABLE "places" (\n'
507507
" [id] INTEGER,\n"
508508
" [name] TEXT,\n"
509-
" [country] INTEGER REFERENCES [country]([id]),\n"
510-
" [continent] INTEGER REFERENCES [continent]([id]),\n"
509+
" [country] INTEGER REFERENCES [country]([id]) ON UPDATE CASCADE ON DELETE CASCADE,\n"
510+
" [continent] INTEGER REFERENCES [continent]([id]) ON UPDATE CASCADE ON DELETE CASCADE,\n"
511511
" [city] INTEGER\n"
512512
")"
513513
)

0 commit comments

Comments
 (0)