Gemini multimodal support #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeremTurgutlu
force-pushed
the
gemini-multimodal-support
branch
from
eebe402 to
4b57207
Compare
Open
KeremTurgutlu
force-pushed
the
gemini-multimodal-support
branch
2 times, most recently
from
032485c to
26fc6af
Compare
jph00
reviewed
Dec 7, 2025
Contributor
jph00
left a comment
jph00
left a comment
There was a problem hiding this comment.
Looking good! A couple of questions for you.
lisette/core.py
Outdated
| (b'\x00\x00\x01\xb3', 0): 'video/mpeg', | ||
| } | ||
|
|
||
| def _detect_mime(data): |
Contributor
There was a problem hiding this comment.
This is nice! I've added it as fastcore.xtras.detect_mime so you can use that instead. :)
Contributor
Author
There was a problem hiding this comment.
Great thank you so much!
|
|
||
| # %% ../nbs/00_core.ipynb | ||
| @patch | ||
| def print_hist(self:Chat): |
Contributor
Author
There was a problem hiding this comment.
Synthetic history utils aren't used anymore, I think they were added for reconstructing tools from formatted outputs? But afaik Rens made a different implementation which doesn't use them. We can probably add back print_hist though.
KeremTurgutlu
force-pushed
the
gemini-multimodal-support
branch
from
26fc6af to
f8c41ca
Compare
Contributor
Author
|
Made a small fix to AnswerDotAI/fastcore#713 @jph00 I've made the changes to use |
KeremTurgutlu
force-pushed
the
gemini-multimodal-support
branch
from
f8c41ca to
4459917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after: AnswerDotAI/fastcore#713
TODO: Need to update the fastcore version in lisette settings.ini once the fastcore PR above is released.
Here are the changes:
completion(..., caching=True)) for non-claude models whenChat(...,cache=True).AsyncStreamFormatterfor non-claude models like Gemini, where thinking can interleave and can also have generation content at the final thinking chunk.