feat(project): Switch to modular Firebase sdk#687
Open
ciriousjoker wants to merge 1 commit intoAnthonyNahas:masterfrom
Open
feat(project): Switch to modular Firebase sdk#687ciriousjoker wants to merge 1 commit intoAnthonyNahas:masterfrom
ciriousjoker wants to merge 1 commit intoAnthonyNahas:masterfrom
Conversation
ciriousjoker
commented
Mar 25, 2023
Contributor
Author
ciriousjoker
left a comment
ciriousjoker
left a comment
There was a problem hiding this comment.
Keep in mind that everything does compile, but my app only uses these features:
- register form (with email/password and Google)
- login form (email/password, Google)
- the "profile dialog thing" with the "delete account" button on it
|
|
||
| <ng-template #authenticated> | ||
| <mat-card *ngIf="auth.user | async as user"> | ||
| <mat-card *ngIf="auth.currentUser as user"> |
Contributor
Author
There was a problem hiding this comment.
This part isn't identical in functionality since this worked perfectly out of the box and I was too lazy to figure out how to get a user stream because of that.
Similar syntax was used in multiple template files, please check/fix those manually.
Contributor
Author
|
@AnthonyNahas can you take a look at this and merge it if possible? |
Contributor
Author
|
@AnthonyNahas reminder to please look at this |
Contributor
Author
|
@AnthonyNahas reminder to please look at this (if you want me to stop, just ping me to shut up) |
Contributor
Author
|
@AnthonyNahas it's been a year, is this thing being maintained at all? |
ciriousjoker
force-pushed
the
switch-to-modular
branch
from
f2a6afd to
4a6aa92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've replaced the old compat imports with the new modular syntax.
I'm using this in production, although it's a relatively small project!