joystickstatuswindow: don't update accel/gyro if closed

[xobs]

Avoid updating the accelerometer or gyroscope values if the window is closed. This prevents a segfault when the window is closed for controllers with accelerometers and gyroscopes, such as DualSense controllers.

[xobs]

Currently, this only fixes the issue if the QDialog is closed by pressing "Esc". It does not fix it when closing by clicking the close box in the upper-right corner of the window.

[xobs]

This was an attempt to fix #1230 but it does not fix the case where the close box is clicked.

[xobs]

I wish Qt would not repaint an object if it didn't exist, but I can't seem to find a way of testing whether an object exists prior to calling setValue(). The problem appears to be that the window decoration is deallocated sometime during the call to setValue(), and then Qt continues to perform the paint operation.

[pktiuk]

Hello @xobs ,

Could you fix formatting in this PR?

[xobs]

Of course. It didn't sit right with me that the fix was only partially successful, so I wanted to come up with a more complete fix. This should now work for both the case where the user clicks the close box on the window decoration, as well as the user clicking the "Close" button. It should also still work for devices with no sensors.

The difference was to delete the whole QDialog box (which will cause it to close), but defer the deletion until the end of the runloop. That way the gyro and accel labels can still be updated, even if the window is closed while the values are getting updated.

I have only tested it under Wayland.

[pktiuk]

Thank you for your contribution. :)