-
Couldn't load subscription status.
- Fork 7.3k
fix: resolve pyperclip installation issue with setuptools compatibility #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: resolve pyperclip installation issue with setuptools compatibility #1326
Conversation
- Pin setuptools to <66.0 and pyperclip to 1.8.2 in requirements - Add installation scripts for Linux/Mac and Windows - Create installation fix documentation - Update README with troubleshooting section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 8852a7b in 1 minute and 48 seconds. Click for details.
- Reviewed
83lines of code in3files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. README.md:144
- Draft comment:
Ensure version specifiers match: README uses 'pyperclip==1.8.2' and 'setuptools<66.0' but scripts use range pinning. Align them for consistency. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment suggests changing version specifiers but provides no evidence of inconsistency with other files. This is a troubleshooting section specifically addressing a known error with specific versions. Changing to a range could potentially introduce new issues. Without seeing the "scripts" mentioned, we can't verify if there's really an inconsistency. I could be wrong if there are scripts elsewhere in the codebase that do use different version specifiers. The range version might actually be more flexible and work just as well. Even if there are scripts elsewhere, this is a troubleshooting section specifically addressing a known error with specific versions that work. Changing to a range here could make the troubleshooting steps less reliable. Delete the comment. The suggested change lacks evidence and could make the troubleshooting steps less reliable by introducing version ranges where specific versions are known to work.
2. scripts/install_fixed.sh:22
- Draft comment:
Add a newline at the end of the file to follow POSIX best practices. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. scripts/install_fixed.ps1:20
- Draft comment:
Add a newline at the end of the file for consistency with standard practices. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_LpUG9yN3o3lCBVyh
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
|
||
| # Update pip to latest version | ||
| echo "Upgrading pip..." | ||
| pip install --upgrade pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'python -m pip' instead of bare 'pip' to ensure the correct Python interpreter is used.
| pip install --upgrade pip | |
| python -m pip install --upgrade pip |
| python -m pip install -e . | ||
|
|
||
| Write-Host "✅ Installation completed successfully!" -ForegroundColor Green | ||
| Write-Host "You can now run: gpte projects/example" No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears there might be a typo in the command at line 20: 'gtpe projects/example'. Did you mean 'gpt projects/example' or 'gpt-engineer projects/example'? Please verify the intended command.
| Write-Host "You can now run: gpte projects/example" | |
| Write-Host "You can now run: gpt-engineer projects/example" |
Important
Fixes
pyperclipinstallation issue by pinningsetuptoolsandpyperclipversions, adding installation scripts, and updating documentation.setuptoolsto<66.0andpyperclipto1.8.2in requirements.install_fixed.ps1for Windows andinstall_fixed.shfor Linux/Mac to handle installation issues.README.mdfor installation errorcanonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'.This description was created by
for 8852a7b. You can customize this summary. It will automatically update as commits are pushed.