Skip to content

Conversation

@SagiROosto
Copy link

This update introduces the IoT provider creation function and adds necessary environment variable definitions for IoT credentials in the AWS module. Additionally, the CMake configuration is updated to include the new IoT credentials source file.

@SagiROosto SagiROosto force-pushed the add-aws-iot-credentials branch 2 times, most recently from dccc981 to cfb2313 Compare August 14, 2025 14:09
Copy link

@yuvalDOosto yuvalDOosto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, added some comments, I have to look at it again due to flb_aws_credential_iot.c length but the current comments are a good start

@SagiROosto SagiROosto force-pushed the add-aws-iot-credentials branch from 7d5c82f to a44c9ab Compare August 18, 2025 07:46
@SagiROosto SagiROosto requested a review from Copilot August 20, 2025 07:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces AWS IoT credentials provider support to Fluent Bit, enabling authentication using IoT device certificates. The implementation adds a new credentials provider that uses IoT-specific environment variables and TLS certificate authentication to obtain temporary AWS credentials from an IoT credentials endpoint.

Key changes:

  • Added complete IoT credentials provider implementation with TLS certificate support
  • Integrated IoT provider into the standard AWS credentials chain
  • Added environment variable definitions for IoT configuration parameters

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
src/aws/flb_aws_credentials_iot.c New IoT credentials provider implementation with certificate-based authentication
src/aws/flb_aws_credentials.c Integration of IoT provider into standard credentials chain
src/aws/CMakeLists.txt Added new IoT credentials source file to build
include/fluent-bit/flb_aws_credentials.h Added IoT environment variable definitions and function declaration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SagiROosto SagiROosto force-pushed the add-aws-iot-credentials branch from 980eb2e to 12cfd40 Compare September 29, 2025 08:00
@SagiROosto
Copy link
Author

since the PR to original repo is from the master branch and still in progress, we'll wait for it to be merged first fluent#10824

@SagiROosto SagiROosto force-pushed the master branch 2 times, most recently from c6119a3 to 7d400e8 Compare November 5, 2025 15:52
Signed-off-by: SagiROosto <[email protected]>
…initions

This update introduces the IoT provider creation function and adds necessary environment variable definitions for IoT credentials in the AWS module. Additionally, the CMake configuration is updated to include the new IoT credentials source file.

Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
@SagiROosto SagiROosto force-pushed the add-aws-iot-credentials branch from 12cfd40 to e73bf6f Compare November 6, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants