-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add IoT provider support and related credentials definitions #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
dccc981 to
cfb2313
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, added some comments, I have to look at it again due to flb_aws_credential_iot.c length but the current comments are a good start
7d5c82f to
a44c9ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces AWS IoT credentials provider support to Fluent Bit, enabling authentication using IoT device certificates. The implementation adds a new credentials provider that uses IoT-specific environment variables and TLS certificate authentication to obtain temporary AWS credentials from an IoT credentials endpoint.
Key changes:
- Added complete IoT credentials provider implementation with TLS certificate support
- Integrated IoT provider into the standard AWS credentials chain
- Added environment variable definitions for IoT configuration parameters
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/aws/flb_aws_credentials_iot.c | New IoT credentials provider implementation with certificate-based authentication |
| src/aws/flb_aws_credentials.c | Integration of IoT provider into standard credentials chain |
| src/aws/CMakeLists.txt | Added new IoT credentials source file to build |
| include/fluent-bit/flb_aws_credentials.h | Added IoT environment variable definitions and function declaration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
980eb2e to
12cfd40
Compare
|
since the PR to original repo is from the master branch and still in progress, we'll wait for it to be merged first fluent#10824 |
c6119a3 to
7d400e8
Compare
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
…initions This update introduces the IoT provider creation function and adds necessary environment variable definitions for IoT credentials in the AWS module. Additionally, the CMake configuration is updated to include the new IoT credentials source file. Signed-off-by: Eduardo Silva <[email protected]> Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
Signed-off-by: SagiROosto <[email protected]>
12cfd40 to
e73bf6f
Compare
This update introduces the IoT provider creation function and adds necessary environment variable definitions for IoT credentials in the AWS module. Additionally, the CMake configuration is updated to include the new IoT credentials source file.