refactor(Ethereum): improve efficiency of SafeProxy detection heuristic #2736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Narrow the heuristic which triggers the
masterCopy()call to a contract to determine if it is a SafeProxy type. This should reduce/eliminate most of the instances where Ape tries the call and it fails and creates a log like so:How I did it
We can add a couple extra ~free checks on code and slot_0 value before triggering
masterCopy():masterCopy()(0xa619486e) is actually in the proxy code (should always be true, but has potential for false positives)How to verify it
Anything weird happens
Checklist
- [ ] Documentation is complete