Skip to content

feat: [Data Contracts] Contract Rule Data Model#7621

Merged
carlesarnal merged 2 commits intoApicurio:mainfrom
matheusandre1:feat-7348
Mar 26, 2026
Merged

feat: [Data Contracts] Contract Rule Data Model#7621
carlesarnal merged 2 commits intoApicurio:mainfrom
matheusandre1:feat-7348

Conversation

@matheusandre1
Copy link
Copy Markdown
Contributor

Pr Closes: #7348

Copy link
Copy Markdown
Member

@carlesarnal carlesarnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The PR is well-aligned with issue #7348 and the Data Contracts epic #6192 — it delivers exactly the Phase 1 foundation data model as specified.

A few improvements to address before merge:

  1. Remove @RegisterForReflection — Existing DTOs in this package (e.g., ArtifactMetaDataDto, EditableArtifactMetaDataDto) do not use this Quarkus annotation. Please remove it from all 3 DTO classes to stay consistent with the codebase conventions.

  2. Replace wildcard Lombok imports with explicit imports — Existing DTOs import each Lombok annotation individually (import lombok.AllArgsConstructor;, import lombok.Builder;, etc.). Please update ContractRuleDto, ContractRuleSetDto, and EditableContractRuleDto to follow the same pattern instead of import lombok.*;.

  3. Add trailing newline to ContractRuleDto.java — The file is missing a newline at the end of the file.

Otherwise, the data model, test coverage, and package placement all look good.

@matheusandre1
Copy link
Copy Markdown
Contributor Author

Thanks for feedback, but, and question

Why not use records? That's a question I have.

@carlesarnal
Copy link
Copy Markdown
Member

Thanks for feedback, but, and question

Why not use records? That's a question I have.

Essentially, we don't use them for two reasons. The first one being that the project was created before records were available and the second, that we build dtos incrementally, with setters etc, something that records don't support.

@carlesarnal carlesarnal merged commit 1eba34d into Apicurio:main Mar 26, 2026
29 checks passed
@matheusandre1 matheusandre1 deleted the feat-7348 branch March 26, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Data Contracts] Contract Rule Data Model

2 participants