feat: [Data Contracts] Contract Rule Data Model#7621
feat: [Data Contracts] Contract Rule Data Model#7621carlesarnal merged 2 commits intoApicurio:mainfrom
Conversation
carlesarnal
left a comment
There was a problem hiding this comment.
Thanks for the contribution! The PR is well-aligned with issue #7348 and the Data Contracts epic #6192 — it delivers exactly the Phase 1 foundation data model as specified.
A few improvements to address before merge:
-
Remove
@RegisterForReflection— Existing DTOs in this package (e.g.,ArtifactMetaDataDto,EditableArtifactMetaDataDto) do not use this Quarkus annotation. Please remove it from all 3 DTO classes to stay consistent with the codebase conventions. -
Replace wildcard Lombok imports with explicit imports — Existing DTOs import each Lombok annotation individually (
import lombok.AllArgsConstructor;,import lombok.Builder;, etc.). Please updateContractRuleDto,ContractRuleSetDto, andEditableContractRuleDtoto follow the same pattern instead ofimport lombok.*;. -
Add trailing newline to
ContractRuleDto.java— The file is missing a newline at the end of the file.
Otherwise, the data model, test coverage, and package placement all look good.
|
Thanks for feedback, but, and question Why not use records? That's a question I have. |
Essentially, we don't use them for two reasons. The first one being that the project was created before records were available and the second, that we build dtos incrementally, with setters etc, something that records don't support. |
Pr Closes: #7348