Fix for Explicit returns mixed with implicit (fall through) returns#163
Merged
redreceipt merged 1 commit intomainfrom Dec 24, 2025
Merged
Fix for Explicit returns mixed with implicit (fall through) returns#163redreceipt merged 1 commit intomainfrom
redreceipt merged 1 commit intomainfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nonereturn.with_retries.wrapper, the best minimal change is to add an explicitreturn func(*args, **kwargs)after the loop, which will only be reached if, for some reason, the loop completes without returning or raising. To preserve current semantics exactly, we should structure it so normal cases are unaffected and any theoretically fall-through path still returns a value of the same type as successful calls.jobs.py, withinwith_retries, modify thewrapperfunction so that after thefor i in range(3): ...loop finishes, there is an explicitreturn func(*args, **kwargs)(or alternatively an explicitreturn Noneif we wanted that behavior; here, matching the normal successful behavior is better).jobs.py.Suggested fixes powered by Copilot Autofix. Review carefully before merging.