Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the leaderboard scoring system by increasing point values for issue priorities. The changes update scoring from a 4/2/1 system to a 10/5/1 system for high/medium/low priority issues respectively.
- Updated scoring logic in both linear.py and jobs.py from 4/2/1 to 10/5/1 points
- Modified tooltip text in the HTML template to reflect new scoring values
- Updated Slack message text to show the new scoring system
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| templates/index.html | Updates tooltip text to show new scoring values (10/5/1) |
| linear.py | Updates priority_to_score mapping and comment to reflect new scoring |
| jobs.py | Updates priority_to_score mapping and Slack message text for new scoring |
| # high - 4, medium - 2, everything else - 1 | ||
| priority_to_score = {1: 4, 2: 4, 3: 2, 4: 1, 5: 1} | ||
| # high - 10, medium - 5, everything else - 1 | ||
| priority_to_score = {1: 10, 2: 10, 3: 5, 4: 1, 5: 1} |
There was a problem hiding this comment.
The priority_to_score mapping is duplicated between linear.py and jobs.py. Consider extracting this to a shared constant or configuration to maintain consistency and reduce duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
python -m py_compile jobs.py linear.py app.py github.py config.py openai_client.pyflake8(fails: command not found)https://chatgpt.com/codex/tasks/task_e_687f1d96a1c08324aace3ceb5abfb9d5