Skip to content

chore(android): support react-native 0.79.0 #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2025
Merged

chore(android): support react-native 0.79.0 #610

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
693ab52
chore(android): support rn 0.79
akuul Apr 11, 2025
ba0e1e0
fix SafeAreaViewManager formatting
akuul Apr 11, 2025
513eb0e
use ReactViewManager
akuul Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions android/src/main/java/com/th3rdwave/safeareacontext/SafeAreaViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,28 +5,22 @@ import com.facebook.react.module.annotations.ReactModule
import com.facebook.react.uimanager.ReactStylesDiffMap
import com.facebook.react.uimanager.StateWrapper
import com.facebook.react.uimanager.ThemedReactContext
import com.facebook.react.uimanager.ViewManagerDelegate
import com.facebook.react.uimanager.annotations.ReactProp
import com.facebook.react.viewmanagers.RNCSafeAreaViewManagerInterface
import com.facebook.react.views.view.ReactViewGroup
import com.facebook.react.views.view.ReactViewManager

@ReactModule(name = SafeAreaViewManager.REACT_CLASS)
class SafeAreaViewManager : ReactViewManager(), RNCSafeAreaViewManagerInterface<SafeAreaView> {
class SafeAreaViewManager : ReactViewManager() {
override fun getName() = REACT_CLASS

// Make sure we're not using delegates for now since ReactViewGroupManager doesn't use one. If it
// does in the future we will need a way to compose delegates together.
override fun getDelegate(): ViewManagerDelegate<ReactViewGroup>? = null

override fun createViewInstance(context: ThemedReactContext) = SafeAreaView(context)

override fun createShadowNodeInstance() = SafeAreaViewShadowNode()

override fun getShadowNodeClass() = SafeAreaViewShadowNode::class.java

@ReactProp(name = "mode")
override fun setMode(view: SafeAreaView, mode: String?) {
fun setMode(view: SafeAreaView, mode: String?) {
when (mode) {
"padding" -> {
view.setMode(SafeAreaViewMode.PADDING)
Expand All @@ -38,7 +32,7 @@ class SafeAreaViewManager : ReactViewManager(), RNCSafeAreaViewManagerInterface<
}

@ReactProp(name = "edges")
override fun setEdges(view: SafeAreaView, propList: ReadableMap?) {
fun setEdges(view: SafeAreaView, propList: ReadableMap?) {
if (propList != null) {
view.setEdges(
SafeAreaViewEdges(
Expand Down