Skip to content

chore: use matrix to build variants on android #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: use matrix to build variants on android #652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a76eb33
Update android.yml
janicduplessis Aug 4, 2025
9c45ee7
Update android.yml
janicduplessis Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 14 additions & 30 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,25 @@ on:
jobs:
android-build:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
newArch: [true, false]
buildType: [Debug, Release]
name: Build (newArch=${{ matrix.newArch }}, buildType=${{ matrix.buildType }})
steps:
- uses: actions/checkout@v4

- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 20.x

- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: '17'

- name: Restore yarn workspaces
id: yarn-cache
uses: actions/cache@v3
Expand All @@ -37,39 +46,14 @@ jobs:
node_modules
*/*/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}

- name: Install dependencies
run: yarn install

- name: Install example app dependencies
run: yarn install
working-directory: example
- name: Build android example app with new arch disabled
run: ./gradlew assembleDebug -PnewArchEnabled=false
working-directory: example/android
android-build-fabric:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 20.x
uses: actions/setup-node@v1
with:
node-version: 20.x
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: '17'
- name: Restore yarn workspaces
id: yarn-cache
uses: actions/cache@v3
with:
path: |
node_modules
*/*/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- name: Install dependencies
run: yarn install
- name: Install example app dependencies
run: yarn install
working-directory: example
- name: Build android example app with new arch enabled
run: ./gradlew assembleDebug -PnewArchEnabled=true

- name: Build Android example app
run: ./gradlew assemble${{ matrix.buildType }} -PnewArchEnabled=${{ matrix.newArch }}
working-directory: example/android
Loading