Skip to content

Conversation

@jsl12
Copy link
Contributor

@jsl12 jsl12 commented May 31, 2025

Added the setter for global_vars and edited some of the docs surrounding globals.

Fixes #2314

@acockburn acockburn merged commit 05ad0f9 into dev May 31, 2025
15 checks passed
@jsl12 jsl12 deleted the global-vars branch May 31, 2025 15:42
@chatziko
Copy link
Contributor

Commit 573858c breaks AD in my system, apps fail to start with the following error:

2025-05-31 22:55:42.209693 ERROR Error: AppInstantiationError: Failed to create object for 'scribble'
2025-05-31 22:55:42.210324 ERROR Error:   AttributeError: property 'app_config' of 'MyApp' object has no setter

Likely we need to also remove the ADBase::app_config @property.

@NodeJSmith
Copy link

@jsl12 @acockburn Is it just me or is the setter for global vars actually setting it to Any, instead of the provided value? Is that on purpose?

@acockburn
Copy link
Member

Hmm, you may have a point ...

@global_vars.setter
    def global_vars(self, value: Any) -> None:
        with self.AD.global_lock:
            self.AD.global_vars = Any

should probably be:

@global_vars.setter
    def global_vars(self, value: Any) -> None:
        with self.AD.global_lock:
            self.AD.global_vars = value

@jsl12 ?

@jsl12
Copy link
Contributor Author

jsl12 commented Jul 18, 2025

Yeah, that looks like an oversight to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: property 'global_vars' of 'StatusNotifier' object has no setter

5 participants